Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 869203

Summary: app-arch/zip-3.0-r4: conflicting types for memset when building with clang-15
Product: Gentoo Linux Reporter: nvinson234
Component: Current packagesAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED FIXED    
Severity: normal CC: sam
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=2143565
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 408963, 870412    
Attachments: build.log
configure.patch

Description nvinson234 2022-09-08 15:29:58 UTC
When building with clang-15 zip generates several errors with the first being a complaint about conflicting types for memset().

Reproducible: Always

Steps to Reproduce:
1. Install clang-15 toolchain
2. Attempt to build zip
3. Observe failure
Actual Results:  
zip fails to build with multiple errors

Expected Results:  
zip builds successfully

Portage 3.0.35 (python 3.10.7-final-0, default/linux/amd64/17.1/desktop, gcc-12.2.0, glibc-2.35-r8, 5.18.14-gentoo x86_64)
=================================================================
System uname: Linux-5.18.14-gentoo-x86_64-Intel-R-_Core-TM-_i7-4771_CPU_@_3.50GHz-with-glibc2.35
KiB Mem:    32557860 total,   9710740 free
KiB Swap:    2097148 total,   2096880 free
Timestamp of repository gentoo: Thu, 08 Sep 2022 06:42:39 +0000
Head commit of repository gentoo: 04afa74351811f84f9e0e430aa24e3c0925b298a

Timestamp of repository brother-overlay: Sun, 04 Sep 2022 19:46:50 +0000
Head commit of repository brother-overlay: 2c208f0df5aa5f9f967c361f0e3ad514e50422d0

Head commit of repository magpie: 1e2d3933828a8341616b68e93c3136e5724d2b66

sh bash 5.1_p16-r2
ld GNU ld (Gentoo 2.39 p4) 2.39.0
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r2::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0::gentoo
dev-lang/python:           3.10.7::gentoo, 3.11.0_rc1_p2::gentoo
dev-lang/rust:             1.62.1::gentoo
dev-util/cmake:            3.24.1::gentoo
dev-util/meson:            0.63.2::gentoo
sys-apps/baselayout:       2.8-r2::gentoo
sys-apps/openrc:           0.45.2::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.13-r2::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.39-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.6-r1::gentoo, 15.0.0::gentoo
sys-devel/gcc:             12.2.0::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             15.0.0::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo, 15.0.0::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.19::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r8::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    sync-git-verify-commit-signature: true

brother-overlay
    location: /var/db/repos/brother-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/brother-overlay.git
    masters: gentoo

magpie
    location: /var/db/repos/magpie
    sync-type: git
    sync-uri: https://github.com/nvinson/magpie.git
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
AR="llvm-ar"
CBUILD="x86_64-pc-linux-gnu"
CC="clang"
CFLAGS="-march=native -O2 -pipe -D_FORTIFY_SOURCE=3 -fstack-protector-strong -flto=thin"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/brother/scanner/brscan4/brsanenetdevice4.cfg /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXX="clang++"
CXXFLAGS="-march=native -O2 -pipe -D_FORTIFY_SOURCE=3 -fstack-protector-strong -flto=thin"
DISTDIR="/var/cache/portage/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=native -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=native -O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -fuse-ld=lld -rtlib=compiler-rt -unwindlib=libunwind"
MAKEOPTS="-j8"
NM="llvm-nm"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RANLIB="llvm-ranlib"
SHELL="/bin/zsh"
USE="X a52 aac acl acpi alsa amd64 branding bzip2 cairo cdda cdr clang cleartype cli corefonts crypt cups dbus dri dts dvd dvdr elogind encode exif flac fortran gdbm gif glamor gpm gtk gui iconv icu ipv6 jpeg lcms libglvnd libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds qt5 readline sdl seccomp spell split-usr ssl startup-notification svg theora tiff truetype udev udisks unicode upower usb vaapi vorbis vpx wxwidgets x264 xattr xcb xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en-US en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, ARFLAGS, AS, ASFLAGS, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 nvinson234 2022-09-08 15:30:46 UTC
Created attachment 804016 [details]
build.log
Comment 2 nvinson234 2022-09-08 15:32:15 UTC
Created attachment 804019 [details, diff]
configure.patch

Error caused by unix/configure failing to properly identify standard functions.  The bundled versions are not compatible with the standard definitions.

This patch fixes the unix/configure script.
Comment 3 Larry the Git Cow gentoo-dev 2022-09-10 02:15:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e20ac65e339e8fe52f62aa43b98a60ffd4dc16ed

commit e20ac65e339e8fe52f62aa43b98a60ffd4dc16ed
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-10 02:15:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-10 02:15:53 +0000

    app-arch/zip: fix build w/ Clang 15
    
    Closes: https://bugs.gentoo.org/869203
    Thanks-to: Nicholas Vinson <nvinson234@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/zip-3.0-clang-15-configure-tests.patch   | 52 ++++++++++++++++
 app-arch/zip/zip-3.0-r5.ebuild                     | 71 ++++++++++++++++++++++
 2 files changed, 123 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2022-09-10 13:30:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4757f8e333a6b23956d6e9a53bac21365e70cc4f

commit 4757f8e333a6b23956d6e9a53bac21365e70cc4f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-10 13:27:54 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-10 13:29:55 +0000

    app-arch/zip: add link to openembedded variant of patch
    
    Bug: https://bugs.gentoo.org/869203
    Signed-off-by: Sam James <sam@gentoo.org>

 app-arch/zip/files/zip-3.0-clang-15-configure-tests.patch | 1 +
 1 file changed, 1 insertion(+)
Comment 5 Larry the Git Cow gentoo-dev 2022-11-19 01:35:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6b9dfb87bb0e636b46ff40111252f96196375e7

commit e6b9dfb87bb0e636b46ff40111252f96196375e7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-11-19 00:35:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-19 01:34:42 +0000

    app-arch/zip: further Clang 16 fixes (just in case)
    
    I only started looking at this because I saw a clang.diff from toralf
    which indicated more problems, but it turned out to be for zip-3.0-r4, not
    -r5/-r6 which had fixes [0][1][2].
    
    -r6 is actually clean wrt clang.diff from the /etc/portage/bashrc hook
    we're using, but I noticed these additional nits while checking over
    configure, so may as well apply these just to be safe.
    
    [0] 5d06aa4c9b99bd1bcbbd8cedeb0a3ca54335905b
    [1] 4757f8e333a6b23956d6e9a53bac21365e70cc4f
    [2] e20ac65e339e8fe52f62aa43b98a60ffd4dc16ed
    
    Bug: https://bugs.gentoo.org/869203
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/zip-3.0-clang-15-configure-tests.patch   | 202 +++++++++++++++++++--
 .../zip/{zip-3.0-r6.ebuild => zip-3.0-r7.ebuild}   |   0
 2 files changed, 184 insertions(+), 18 deletions(-)