Bug 868384 – dev-libs/libgcrypt: libgcrypt-config --libs gives fgrep warning with sys-apps/grep-3.8 (net-misc/grive-0.5.2_pre20211128-r1:0 - CMake Error at libgrive/CMakeLists.txt:75 (add_library))

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Toralf Förster 2022-09-04 08:03:50 UTC]

CMake Warning:
  Value of grive_LIB_DEPENDS contained a newline; truncating
CMake Error at libgrive/CMakeLists.txt:75 (add_library):
  Target "grive" links to item " using /bin/grep -F

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no_multilib_systemd-j4-20220901-160008

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-12.2.0 *
clang/llvm (if any):
clang version 14.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/14/bin
/usr/lib/llvm/14
14.0.6
Python 3.10.6
Available Ruby profiles:
  (none found)
Available Rust versions:
  [1]   rust-bin-1.62.1 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 11.0.15_p10 [openjdk-bin-11]
*)	Eclipse Temurin JDK 17.0.3_p7 [openjdk-bin-17]
3)	Eclipse Temurin JDK 8.332_p09 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8 
  [2]   openjdk-bin-11 
  [3]   openjdk-bin-17  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.0.2
php cli:
  [1]   php8.1 *
GNU Make 4.3

  HEAD of ::gentoo
commit 2ecd4bcf83f3e1da48faec9d004ebef4c9ea4d03
Author: Repository mirror & CI <[e-mail]>
Date:   Sun Sep 4 01:31:45 2022 +0000

    2022-09-04 01:31:45 UTC

emerge -qpvO net-misc/grive
[ebuild  N    ] net-misc/grive-0.5.2_pre20211128-r1

[Comment 1 Toralf Förster 2022-09-04 08:03:51 UTC]

Created attachment 803152 [details]
emerge-info.txt

[Comment 2 Toralf Förster 2022-09-04 08:03:53 UTC]

Created attachment 803155 [details]
emerge-history.txt.bz2

[Comment 3 Toralf Förster 2022-09-04 08:03:54 UTC]

Created attachment 803158 [details]
environment

[Comment 4 Toralf Förster 2022-09-04 08:03:55 UTC]

Created attachment 803161 [details]
etc.portage.tar.bz2

[Comment 5 Toralf Förster 2022-09-04 08:03:56 UTC]

Created attachment 803164 [details]
logs.tar.bz2

[Comment 6 Toralf Förster 2022-09-04 08:03:57 UTC]

Created attachment 803167 [details]
net-misc:grive-0.5.2_pre20211128-r1:20220904-023607.log

[Comment 7 Toralf Förster 2022-09-04 08:03:58 UTC]

Created attachment 803170 [details]
temp.tar.bz2

[Comment 8 Andrew Udvare 2022-09-04 08:40:14 UTC]

Downgrading to grep 3.7 allows the build to work. The warning output from 3.8 is breaking things.

[Comment 9 Christoph Junghans (RETIRED) 2022-09-11 17:11:05 UTC]

This is actually an issue in libgcrypt-config, not grive.

Grive's CMake is calling "libgcrypt-config --libs" and "libgcrypt-config --cflags" which uses fgrep and produces that warning.

[Comment 10 Sam James 2022-09-11 17:41:33 UTC]

(In reply to Christoph Junghans from comment #9)
> This is actually an issue in libgcrypt-config, not grive.
> 
> Grive's CMake is calling "libgcrypt-config --libs" and "libgcrypt-config
> --cflags" which uses fgrep and produces that warning.

Two comments:
1. It sends that to stderr and I wouldn't expect that to impact usage here, as the error code indeed remains successful?

2. grive should really be using pkg-config anyway (PKG_CHECK_MODULES).

But it's an issue that libgcrypt whines anyway so I'll fix that.

[Comment 11 Larry the Git Cow 2022-09-11 17:49:03 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1b7bc443ed4de4e83812e7cd360c9bcc9bb8e3a

commit d1b7bc443ed4de4e83812e7cd360c9bcc9bb8e3a
Author:     Sam James <[e-mail]>
AuthorDate: 2022-09-11 17:48:45 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-09-11 17:48:45 +0000

    dev-libs/libksba: fix fgrep warnings in ksba-config
    
    Closes: https://bugs.gentoo.org/868384
    Signed-off-by: Sam James <[e-mail]>

 .../files/libksba-1.6.0-no-fgrep-ksba-config.patch  | 21 +++++++++++++++++++++
 ...libksba-1.6.0.ebuild => libksba-1.6.0-r1.ebuild} |  7 ++++++-
 2 files changed, 27 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89403d02a8a9cfdf3ed6356159505774f0b501c2

commit 89403d02a8a9cfdf3ed6356159505774f0b501c2
Author:     Sam James <[e-mail]>
AuthorDate: 2022-09-11 17:45:13 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-09-11 17:45:13 +0000

    dev-libs/libgcrypt: fix fgrep warnings in libgcrypt-config
    
    Closes: https://bugs.gentoo.org/868384
    Signed-off-by: Sam James <[e-mail]>

 .../libgcrypt-1.9.4-no-fgrep-libgcrypt-config.patch | 21 +++++++++++++++++++++
 ...-1.10.1-r1.ebuild => libgcrypt-1.10.1-r2.ebuild} |  1 +
 ...pt-1.9.4-r1.ebuild => libgcrypt-1.9.4-r2.ebuild} |  1 +
 3 files changed, 23 insertions(+)