| Summary: | Tooltips for 'stable' and 'testing' are reversed; i.e. mouseover '~amd64' and get '${PV} is stable on amd64' | ||
|---|---|---|---|
| Product: | Websites | Reporter: | Matt Jolly <kangie> |
| Component: | Packages | Assignee: | Gentoo Packages Website <gpackages> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gentoo, smaniotto.nicola |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://packages.gentoo.org/packages/added | ||
| See Also: | https://github.com/gentoo/soko/pull/9 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
I've identified the issue in the template; will submit a PR/MR *** Bug 802612 has been marked as a duplicate of this bug. *** This issue came up recently in the forums. I note that Matt indicated he had the fix and would make a pull request. The needed change is trivial, yet in five months this has not been acted upon. So here is a reminder to people who might be able to address it.
As I noted in the forums, I found what I believe to be the proper repo for the code behind packages.gentoo.org, namely gitweb.gentoo.org/sites/soko.git. This repo has seen a lot of recent activity, so I think I have the right one. The file appears to be web/templates/packages/changedVersionRow.tmpl, and the offending lines are
<span class="label kk-keyword-stable" title="{{$.Version}} is testing on {{.}}">{{.}}</span>
and
<span class="label kk-keyword-testing" title="{{$.Version}} is stable on {{.}}">~{{.}}</span>
In both cases, there is a disparity between the word "testing" or "stable" in the title text and the corresponding CSS class name. The first line should have "stable" in both places and the second line should have "testing".
Unfortunately, since I don't have the setup to run a test instance of the site, I am not in a position to verify any fixes.
FWIW https://github.com/gentoo/soko/pull/9 has the fixes and has been sitting since September. Any gentoo dev can commit to this repo, so its mostly finding an interested party. Today that party can be me. -A |
Tooltips for 'stable' and 'testing' on packages.gentoo.org are reversed; i.e. mouseover '~amd64' and get '${PV} is stable on amd64' Example URIs: https://packages.gentoo.org/packages/added https://packages.gentoo.org/arches Reproducible: Always Steps to Reproduce: 1. Navigate to an impacted packages URI 2. Mouseover ~arch or arch Actual Results: ~arch is 'stable' and arch is 'testing' Expected Results: ~arch is 'testing' and arch is 'stable'