Bug 867076

Summary:	app-portage/portage-utils: QA issues
Product:	Gentoo Linux	Reporter:	David Seifert <soap>
Component:	Current packages	Assignee:	Fabian Groffen <grobian>
Status:	RESOLVED FIXED
Severity:	normal	CC:	qa
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/27044 https://bugs.gentoo.org/show_bug.cgi?id=890752
Whiteboard:
Package list:		Runtime testing required:	---

Description David Seifert gentoo-dev

2022-08-28 11:37:55 UTC

The current ebuilds have a number of QA issues:

1. There's an "nls" USE flag that is never used.

2. The -9999 version inherits autotools, but never uses it.

3. We don't depend on OpenMP in compilers. What if I wanted to use it with icc? The correct way to ask for OpenMP support is to do a pkg_pretend+pkg_setup check, e.g. https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-python/graph-tool/graph-tool-2.45.ebuild#n47

4. All the dependencies for static? are in RDEPEND, even though they will not be needed at runtime. These should all be exclusively in DEPEND.

5. The static? dependencies all have subslot operators, which again are only meaningful for RDEPENDs, which as the previous point said, are wrong.

6. For the runtime/!static? dependencies, we don't specify slots for OpenSSL anymore (because we have compat packages for that).

7. Using USE=static with $(use_enable static) is completely wrong, because this only determines whether libtool also builds static libraries in addition to shared libraries. This requires separate treatment with append-ldflags.

Comment 1 Fabian Groffen gentoo-dev

2022-08-28 12:35:51 UTC

Ok, wow, that's a lot of issues for such a small ebuild :(

Comment 2 Larry the Git Cow gentoo-dev

2022-08-28 21:42:58 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=152cba16dd90e36b4e8abd4c4445adee321a37d3

commit 152cba16dd90e36b4e8abd4c4445adee321a37d3
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2022-08-28 21:42:45 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2022-08-28 21:42:45 +0000

    app-portage/portage-utils: add 0.94.2
    
    Closes: https://bugs.gentoo.org/867076
    Bug: https://bugs.gentoo.org/841898
    Signed-off-by: David Seifert <soap@gentoo.org>

 app-portage/portage-utils/Manifest                 |  1 +
 .../portage-utils/portage-utils-0.94.2.ebuild      | 75 ++++++++++++++++++++++
 2 files changed, 76 insertions(+)