Bug 866947 – dev-libs/icu-71.1-r1 fails tests (lto): compactdecimalformattest.cpp:24:16: error: type struct ExpectedResult violates the C++ One Definition Rule [-Werror=odr]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-08-27 08:31:42 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/icu-71.1-r1 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-08-27 08:31:46 UTC]

Created attachment 801451 [details]
build.log

build log and emerge --info

[Comment 2 Kostadin Shishmanov 2023-11-19 19:32:46 UTC]

Upstream bug: https://unicode-org.atlassian.net/jira/software/c/projects/ICU/issues/ICU-22001

[Comment 3 Paolo Pedroni 2024-02-11 16:35:40 UTC]

Same on dev-libs/icu-73.2

[Comment 4 Larry the Git Cow 2024-04-10 02:30:20 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a6c40d35ca61948c30fd5f4b729df2919bf6ba8a

commit a6c40d35ca61948c30fd5f4b729df2919bf6ba8a
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-04-09 23:18:17 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-04-10 02:30:01 +0000

    dev-libs/icu: mark as LTO-unsafe
    
    It is a test-only unsafety, but this prevents testing that the LTO'ed
    version works.
    
    Closes: https://bugs.gentoo.org/866947
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 dev-libs/icu/icu-74.2.ebuild | 8 ++++++++
 1 file changed, 8 insertions(+)

[Comment 5 Larry the Git Cow 2024-05-02 06:49:42 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c6ab8dd87b5ab288678671e1e5c6beea18ec528

commit 3c6ab8dd87b5ab288678671e1e5c6beea18ec528
Author:     Sam James <[e-mail]>
AuthorDate: 2024-05-02 06:48:23 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-02 06:49:04 +0000

    dev-libs/icu-layoutex: add 75.1 (unkeyworded)
    
    This adds another filter-lto which I've mentioned on the upstream bug.
    
    Bug: https://unicode-org.atlassian.net/browse/ICU-22001
    Bug: https://bugs.gentoo.org/866947
    Signed-off-by: Sam James <[e-mail]>

 dev-libs/icu-layoutex/Manifest                 |   2 +
 dev-libs/icu-layoutex/icu-layoutex-75.1.ebuild | 131 +++++++++++++++++++++++++
 2 files changed, 133 insertions(+)

[Comment 6 Larry the Git Cow 2024-11-10 19:49:05 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=42930f4b96c926bf59bae0b715b5df14ef14a837

commit 42930f4b96c926bf59bae0b715b5df14ef14a837
Author:     Sam James <[e-mail]>
AuthorDate: 2024-11-10 19:39:03 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-11-10 19:48:20 +0000

    dev-libs/icu: add 76.1
    
    Bug: https://bugs.gentoo.org/942694
    Bug: https://bugs.gentoo.org/866947
    Signed-off-by: Sam James <[e-mail]>

 dev-libs/icu/Manifest                             |   2 +
 dev-libs/icu/files/icu-76.1-remove-bashisms.patch | 151 ++++++++++++++++++
 dev-libs/icu/icu-76.1.ebuild                      | 178 ++++++++++++++++++++++
 3 files changed, 331 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7f8b403a9b5197c0f7965b6873094a26506f80e

commit d7f8b403a9b5197c0f7965b6873094a26506f80e
Author:     Sam James <[e-mail]>
AuthorDate: 2024-11-10 19:38:43 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-11-10 19:48:19 +0000

    dev-libs/icu-layoutex: add 76.1
    
    Bug: https://bugs.gentoo.org/942694
    Bug: https://bugs.gentoo.org/866947
    Signed-off-by: Sam James <[e-mail]>

 dev-libs/icu-layoutex/Manifest                     |   2 +
 .../files/icu-layoutex-76.1-remove-bashisms.patch  | 151 +++++++++++++++++++++
 dev-libs/icu-layoutex/icu-layoutex-76.1.ebuild     | 135 ++++++++++++++++++
 3 files changed, 288 insertions(+)