Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 866809

Summary: dev-lang/python-exec-2.4.9 fails tests (lto)
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Python Gentoo Team <python>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 618550    
Attachments: build.log
1-config.log

Description Agostino Sarubbo gentoo-dev 2022-08-26 18:16:41 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-lang/python-exec-2.4.9 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-26 18:16:45 UTC
Created attachment 801208 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-26 18:16:46 UTC
Created attachment 801211 [details]
1-config.log

1-config.log
Comment 3 Agostino Sarubbo gentoo-dev 2022-08-26 18:16:48 UTC
Error(s) that match a know pattern:


E               subprocess.CalledProcessError: Command '['pypy3', 'test/data/test']' returned non-zero exit status 1.
FAILED test/test_core.py::test___file__[pypy3-copy] - subprocess.CalledProces...
FAILED test/test_core.py::test___file__[pypy3-symlink] - subprocess.CalledPro...
FAILED test/test_core.py::test_single[pypy3-copy-python-exec2-{python}-python-None-0]
FAILED test/test_core.py::test_single[pypy3-symlink-python-exec2-{python}-python-None-0]
RecursionError: maximum recursion depth exceeded
Comment 4 Larry the Git Cow gentoo-dev 2022-08-27 06:38:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b43ee416f8c2b60bae3684fff4e9ccbcf8a1eb7c

commit b43ee416f8c2b60bae3684fff4e9ccbcf8a1eb7c
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-08-27 06:35:10 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-08-27 06:37:57 +0000

    dev-python/pypy3: Fix installed "epython" module
    
    Closes: https://bugs.gentoo.org/866809
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/pypy3/{pypy3-7.3.9_p5.ebuild => pypy3-7.3.9_p5-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)