|Summary:||app-arch/lz4: fix tests|
|Product:||Gentoo Linux||Reporter:||Sam James <sam>|
|Component:||Current packages||Assignee:||Michał Górny <mgorny>|
|Package list:||Runtime testing required:||---|
Description Sam James 2022-08-23 05:10:29 UTC
Please bump to 1.9.4. It looks like the tests aren't actually being run and the CMake build lacks support for them: ``` >>> Test phase: app-arch/lz4-1.9.3-r1 * abi_x86_32.x86: running multilib-minimal_abi_src_test * Source directory (CMAKE_USE_DIR): "/var/tmp/portage/app-arch/lz4-1.9.3-r1/work/lz4-1.9.3/build/cmake" * Build directory (BUILD_DIR): "/var/tmp/portage/app-arch/lz4-1.9.3-r1/work/lz4-1.9.3_build-abi_x86_32.x86" No tests found. Skipping. * abi_x86_64.amd64: running multilib-minimal_abi_src_test * Source directory (CMAKE_USE_DIR): "/var/tmp/portage/app-arch/lz4-1.9.3-r1/work/lz4-1.9.3/build/cmake" * Build directory (BUILD_DIR): "/var/tmp/portage/app-arch/lz4-1.9.3-r1/work/lz4-1.9.3_build-abi_x86_64.amd64" No tests found. Skipping. >>> Completed testing app-arch/lz4-1.9.3-r1 ``` Given the alternative is either the Makefiles in the toplevel dir or Meson in contrib/, I'd suggest switching to Meson. But we use the Makefiles for zstd (which is by the same author etc) given nothing else is declared supported. Up to you.
Comment 1 Sam James 2022-08-23 05:12:19 UTC
(In reply to Sam James from comment #0) > > Given the alternative is either the Makefiles in the toplevel dir or Meson > in contrib/, I'd suggest switching to Meson. But we use the Makefiles for > zstd (which is by the same author etc) given nothing else is declared > supported. Up to you. Actually, given https://github.com/lz4/lz4/pull/1139, just switch to plain Makefiles I guess.
Comment 2 Sam James 2022-08-30 12:00:14 UTC
Ping. Bump didn't tackle tests: https://github.com/gentoo/gentoo/commit/188f726d3471bb3313b9b28fcc450f9ea5cf25b3.
Comment 3 Sam James 2022-08-30 22:44:27 UTC
Some history: commit 4dd64bfda2e52623b4d820f6d96003afc1460101 Author: Richard Yao <firstname.lastname@example.org> Date: Sun Oct 13 11:17:04 2013 +0000 Add app-arch/lz4-0_p106 (snapshot of upstream r106), which is initially keyworded on ~amd64 (additional keywords welcome); invoke cmake_src_prepare() in src_prepare() Package-Manager: portage-2.2.7/cvs/Linux x86_64 Manifest-Sign-Key: 0xBEE84C64 commit cb57f158e10e62dc036a990816bcdeba0b4165b9 Author: Michał Górny <email@example.com> Date: Thu Jul 24 21:19:23 2014 +0000 Use the development branch. Switch back to plain Makefile which is better supported upstream. Enable tests. Enable multilib support. Package-Manager: portage-2.2.10/cvs/Linux x86_64 Manifest-Sign-Key: 0xEFB4464E! commit ed6a2132e43a7d9c00b1bbe6b9a14edc6a0c06f0 Author: Michał Górny <firstname.lastname@example.org> Date: Tue Jan 3 18:13:14 2017 +0100 app-arch/lz4: update -9999, switch to CMake Update the URLs in the live ebuild and switch it to use the CMake build system. It is free of all fancy things we had to hack around in Makefiles, and links all executables to the shared library. It lacks tests but they were not very useful anyway.