Bug 865943 – app-office/kmymoney-5.1.3 fails to compile (lto): menuenums.h:18:12: error: type eMenu::Action violates the C++ One Definition Rule [-Werror=odr]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-08-21 14:53:34 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-office/kmymoney-5.1.3 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-08-21 14:53:37 UTC]

Created attachment 800371 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

[Comment 2 Agostino Sarubbo 2022-08-21 14:53:39 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


  Could not find a package configuration file provided by "LibIcal" with any
  Could not find a package configuration file provided by "aqbanking"
  Could not find a package configuration file provided by "gwengui-cpp" with
  Could not find a package configuration file provided by "gwengui-qt5" with
  Could not find a package configuration file provided by "gwenhywfar"
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Could NOT find KF5Activities: found neither KF5ActivitiesConfig.cmake nor kf5activities-config.cmake 
-- Could NOT find KF5Akonadi: found neither KF5AkonadiConfig.cmake nor kf5akonadi-config.cmake 
-- Could NOT find KF5Contacts: found neither KF5ContactsConfig.cmake nor kf5contacts-config.cmake 
-- Could NOT find KF5Holidays: found neither KF5HolidaysConfig.cmake nor kf5holidays-config.cmake 
-- Could NOT find KF5IdentityManagement: found neither KF5IdentityManagementConfig.cmake nor kf5identitymanagement-config.cmake 
-- Could NOT find Subversion (missing: Subversion_SVN_EXECUTABLE) (Required is at least version "1.4")
/var/tmp/portage/app-office/kmymoney-5.1.3/work/kmymoney-5.1.3/kmymoney/plugins/sql/kgeneratesqldlg.cpp:221:63: warning: ‘int QSqlError::number() const’ is deprecated [-Wdeprecated-declarations]
/var/tmp/portage/app-office/kmymoney-5.1.3/work/kmymoney-5.1.3/kmymoney/plugins/sql/mymoneystoragesql_p.h:2014:64: warning: ‘int QSqlError::number() const’ is deprecated [-Wdeprecated-declarations]
/var/tmp/portage/app-office/kmymoney-5.1.3/work/kmymoney-5.1.3/kmymoney/plugins/sql/mymoneystoragesql_p.h:2019:61: warning: ‘int QSqlError::number() const’ is deprecated [-Wdeprecated-declarations]
/var/tmp/portage/app-office/kmymoney-5.1.3/work/kmymoney-5.1.3/kmymoney/plugins/sql/tests/../mymoneystoragesql_p.h:2014:64: warning: ‘int QSqlError::number() const’ is deprecated [-Wdeprecated-declarations]
/var/tmp/portage/app-office/kmymoney-5.1.3/work/kmymoney-5.1.3/kmymoney/plugins/sql/tests/../mymoneystoragesql_p.h:2019:61: warning: ‘int QSqlError::number() const’ is deprecated [-Wdeprecated-declarations]
FAILED: bin/kmymoney 
In file included from /usr/include/qt5/QtSql/QSqlError:1,
  121 |                     qWarning("Could not load plugin '%s', error: %s", qPrintable((*it).fileName()), qPrintable(loader.errorString()));

[Comment 3 Larry the Git Cow 2024-05-03 03:35:17 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0a657afc975a63be7812210b6f4c7856dd1e88e

commit d0a657afc975a63be7812210b6f4c7856dd1e88e
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-05-03 03:33:40 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-03 03:34:25 +0000

    app-office/kmymoney: mark as LTO-unsafe
    
    Closes: https://bugs.gentoo.org/865943
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 app-office/kmymoney/kmymoney-5.1.3.ebuild | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)