Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 865681

Summary: sci-libs/caffe2 should support >=dev-cpp/glog-0.5.0
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Component: Current packagesAssignee: Tupone Alfredo <tupone>
Status: RESOLVED FIXED    
Severity: normal CC: telans
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: caffe2-1.12.0-glog-0.6.0.patch

Description Arfrever Frehtes Taifersar Arahesis 2022-08-18 11:04:32 UTC 
Ebuilds of sci-libs/caffe2 currently have dependency on "<dev-cpp/glog-0.5.0" due to:
https://github.com/pytorch/pytorch/issues/58054 (according to https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c2af9aa14e6a116c72cc0722948988ccffc65cb)

However some attempts of fixes are available.


GLog with commit 81e0d616edeb73cbd06d6c40bc4f90593ac0c5d1 (https://github.com/google/glog/commit/81e0d616edeb73cbd06d6c40bc4f90593ac0c5d1) provides function google::IsGoogleLoggingInitialized().
This commit is included in vanilla GLog 0.6.0, but was also backported to Gentoo GLog 0.5.0:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d87191d729e19343fdf66df33b2786a9f0cb68a
https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-cpp/glog/files/glog-0.5.0-IsGoogleLoggingInitialized_public.patch?id=6d87191d729e19343fdf66df33b2786a9f0cb68a

So after switching to using function google::IsGoogleLoggingInitialized(), dependency can be changed to ">=dev-cpp/glog-0.5.0" instead of ">=dev-cpp/glog-0.6.0".

Changes of soname and subslot are possible (it happened between GLog 0.5.0 and 0.6.0), so ":=" operator should be used: ">=dev-cpp/glog-0.5.0:=".
Comment 1 Arfrever Frehtes Taifersar Arahesis 2022-08-18 11:06:48 UTC 
Created attachment 800053 [details, diff]
caffe2-1.12.0-glog-0.6.0.patch
Comment 2 Larry the Git Cow gentoo-dev 2022-09-05 06:40:48 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f34c4d94727a44935b381b06d00367a2755930a

commit 3f34c4d94727a44935b381b06d00367a2755930a
Author:     Alfredo Tupone <tupone@gentoo.org>
AuthorDate: 2022-09-05 06:40:29 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2022-09-05 06:40:29 +0000

    sci-libs/caffe2: support glog-0.5.0
    
    Closes: https://bugs.gentoo.org/865681
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 sci-libs/caffe2/caffe2-1.12.0.ebuild               |  3 ++-
 .../caffe2/files/caffe2-1.12.0-glog-0.6.0.patch    | 29 ++++++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)