Bug 865267 – app-admin/fsvs-1.2.5-r2 calls commands that do not exist: tags

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-08-15 18:23:03 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/fsvs-1.2.5-r2 calls commands that do not exist.
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Please look for 'command not found' and/or 'no such file or directory'.

[Comment 1 Agostino Sarubbo 2022-08-15 18:23:05 UTC]

Created attachment 799763 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-08-15 18:23:06 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


/bin/sh: line 1: tags: No such file or directory
hash_ops.h:13:10: fatal error: db.h: No such file or directory
/usr/include/subversion-1/svn_types.h:261:26: error: missing binary operator before token "("

[Comment 3 Larry the Git Cow 2023-10-08 11:04:11 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=791c798075c28274952bc276588a9ce8c79f43a7

commit 791c798075c28274952bc276588a9ce8c79f43a7
Author:     David Seifert <[e-mail]>
AuthorDate: 2023-10-08 11:04:01 +0000
Commit:     David Seifert <[e-mail]>
CommitDate: 2023-10-08 11:04:01 +0000

    app-admin/fsvs: drop 1.2.5-r2
    
    Closes: https://github.com/gentoo/gentoo/pull/32436
    Closes: https://bugs.gentoo.org/439204
    Closes: https://bugs.gentoo.org/693650
    Closes: https://bugs.gentoo.org/729112
    Closes: https://bugs.gentoo.org/830267
    Closes: https://bugs.gentoo.org/865267
    Closes: https://bugs.gentoo.org/875677
    Signed-off-by: David Seifert <[e-mail]>

 app-admin/fsvs/Manifest                         |  1 -
 app-admin/fsvs/files/fsvs-1.2.5-as-needed.patch | 31 -------------
 app-admin/fsvs/fsvs-1.2.5-r2.ebuild             | 60 -------------------------
 3 files changed, 92 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58f2ca73cb9d631c1b90a6590e320711419127be

commit 58f2ca73cb9d631c1b90a6590e320711419127be
Author:     Joseph McElroy <[e-mail]>
AuthorDate: 2023-10-08 11:04:00 +0000
Commit:     David Seifert <[e-mail]>
CommitDate: 2023-10-08 11:04:00 +0000

    app-admin/fsvs: add 1.2.11
    
    Bug: https://bugs.gentoo.org/439204
    Bug: https://bugs.gentoo.org/693650
    Bug: https://bugs.gentoo.org/729112
    Bug: https://bugs.gentoo.org/830267
    Bug: https://bugs.gentoo.org/865267
    Bug: https://bugs.gentoo.org/875677
    Closes: https://bugs.gentoo.org/912970
    Signed-off-by: Joseph McElroy <[e-mail]>
    Signed-off-by: David Seifert <[e-mail]>

 app-admin/fsvs/Manifest                         |  1 +
 app-admin/fsvs/files/fsvs-1.2.11-makefile.patch | 68 +++++++++++++++++++++++++
 app-admin/fsvs/fsvs-1.2.11.ebuild               | 55 ++++++++++++++++++++
 3 files changed, 124 insertions(+)