Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 864809

Summary: net-misc/turbovnc [-java] can't be installed along net-misc/tigervnc [-server]
Product: Gentoo Linux Reporter: Zentoo <b4b1>
Component: Current packagesAssignee: Viorel Munteanu <ceamac>
Status: RESOLVED FIXED    
Severity: normal CC: b4b1, sam
Priority: Normal Keywords: PATCH, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/26948
https://github.com/gentoo/gentoo/pull/29105
Whiteboard:
Package list:
Runtime testing required: ---

Description Zentoo 2022-08-10 15:34:48 UTC
net-misc/turbovnc provides:
- vncserver
- if USE=java vncviewer

net-misc/tigervnc provides:
- if USE=server vncserver
- vncviewer

So it should be possible to use net-misc/turbovnc[-java] vncserver with net-misc/tigervnc[-server] vncviewer but net-misc/turbovnc ebuild refuses to emerge if net-misc/tigervnc is installed.

So turbovnc should refuse to install along tigervnc only if:
- using java USE flag
- tigervnc is installed with server USE flag

And tigervnc sould refuses to install along turbovnc if:
- using server USE flag
- turbovnc is installed with java USE flag
Comment 1 Larry the Git Cow gentoo-dev 2022-09-05 12:37:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f13ace2b6ddd8681e8aed1e24ebef92d9fc4f5d

commit 3f13ace2b6ddd8681e8aed1e24ebef92d9fc4f5d
Author:     Viorel Munteanu <ceamac.paragon@gmail.com>
AuthorDate: 2022-08-21 17:40:26 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-09-05 12:37:13 +0000

    net-misc/turbovnc: add 3.0.1
    
    Bug: https://bugs.gentoo.org/864809
    Closes: https://bugs.gentoo.org/865919
    Signed-off-by: Viorel Munteanu <ceamac.paragon@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-misc/turbovnc/Manifest              |   1 +
 net-misc/turbovnc/turbovnc-3.0.1.ebuild | 103 ++++++++++++++++++++++++++++++++
 2 files changed, 104 insertions(+)
Comment 2 Zentoo 2022-11-10 11:00:03 UTC
Thanks I confirm that it's possible now to use
- vncserver from turbovnc
- vncviewer from tigervnc

Note: description of "java" USE flag for net-misc/turbovnc actually is "Add support for Java".
It can be more explicit and tell that java USE flag bring vncviewer.
Someting like: "Add support for Java. Build vncviewer"
Comment 3 gen2dev 2023-01-11 20:19:31 UTC
Building the tigervnc 1.12.0 viewer is optional in the source. That would be good for turbovnc coexistence, and would avoid pulling in fltk and it's dependencies on server-only systems since only the viewer needs fltk.

Please add a 'viewer' use flag to make building the viewer optional. Or you might rather make it a "client" flag to match the turbovnc ebuild, though that doesn't match the option name in the tigervnc source.

The following works for me. I waive all copyright or license claims to it. Use it as you will.

--- tigervnc-1.12.0-r7.ebuild.orig      2022-08-13 23:40:20.000000000 -0400
+++ tigervnc-1.12.0-r7.ebuild   2023-01-10 23:52:23.496933348 -0500
@@ -19,7 +19,7 @@
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="~alpha amd64 arm ~arm64 ~hppa ~ia64 ~loong ~mips ppc ppc64 ~riscv ~sparc x86"
-IUSE="dri3 +drm gnutls java nls +opengl +server xinerama"
+IUSE="dri3 +drm gnutls java nls +opengl +server +viewer xinerama"
 REQUIRED_USE="
        dri3? ( drm )
        opengl? ( server )
@@ -28,7 +28,6 @@
 CDEPEND="
        media-libs/libjpeg-turbo:=
        sys-libs/zlib:=
-       x11-libs/fltk:1
        x11-libs/libX11
        x11-libs/libXext
        x11-libs/libXi
@@ -56,6 +55,7 @@
                x11-misc/xkeyboard-config
                opengl? ( media-libs/libglvnd[X] )
        )
+       viewer? ( x11-libs/fltk:1 )
        "
 
 RDEPEND="${CDEPEND}
@@ -116,6 +116,7 @@
                -DENABLE_NLS=$(usex nls)
                -DBUILD_JAVA=$(usex java)
                -DBUILD_SERVER=$(usex server)
+               -DBUILD_VIEWER=$(usex viewer)
        )
 
        cmake_src_configure
Comment 4 Larry the Git Cow gentoo-dev 2023-01-15 08:39:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a05eb623a0e4247c256e9dd5a239090141fd7378

commit a05eb623a0e4247c256e9dd5a239090141fd7378
Author:     Viorel Munteanu <ceamac@gentoo.org>
AuthorDate: 2023-01-14 18:55:21 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2023-01-15 08:39:16 +0000

    net-misc/turbovnc: rename USE client-> viewer
    
    `viewer` makes more sense than `client`.  It also matches the USE flag
    in tigervnc.
    
    Closes: https://bugs.gentoo.org/864809
    Closes: https://github.com/gentoo/gentoo/pull/29105
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 net-misc/turbovnc/metadata.xml          |  2 +-
 net-misc/turbovnc/turbovnc-3.0.2.ebuild | 32 ++++++++++++++++----------------
 2 files changed, 17 insertions(+), 17 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61edb13feb920235ca828256639512b68d8de066

commit 61edb13feb920235ca828256639512b68d8de066
Author:     Viorel Munteanu <ceamac@gentoo.org>
AuthorDate: 2023-01-14 18:50:54 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2023-01-15 08:39:16 +0000

    net-misc/tigervnc: add 1.12.90
    
    This is called "1.13.0 Beta" in their release page, so try to get ready
    for "1.13.0": https://github.com/TigerVNC/tigervnc/releases/tag/v1.12.90
    
    Also add viewer USE flag to complement turbovnc.  I tested and I can
    install and run both combinations of {tiger,turbo}vnc {server,viewer}
    
    Sync live (live is 1.13.80 now)
    
    Bug: https://bugs.gentoo.org/864809
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 net-misc/tigervnc/Manifest                         |   1 +
 .../files/tigervnc-1.13.80-depend-po-files.patch   |  36 ++++
 net-misc/tigervnc/metadata.xml                     |   4 +-
 net-misc/tigervnc/tigervnc-1.12.90.ebuild          | 227 +++++++++++++++++++++
 net-misc/tigervnc/tigervnc-9999.ebuild             |  72 ++++---
 5 files changed, 316 insertions(+), 24 deletions(-)