| Summary: | sci-mathematics/octave-7.2.0 lacks magick support | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Fabio Rossi <rossi.f> |
| Component: | Current packages | Assignee: | Gentoo Science Mathematics related packages <sci-mathematics> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mjo, sam |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://savannah.gnu.org/bugs/index.php?63331 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | build_failure_imagemagick.log.gz | ||
|
Description
Fabio Rossi
2022-08-10 11:59:36 UTC
what failure do you get when you try to force ImageMagick via configure? (In reply to Sam James from comment #1) > what failure do you get when you try to force ImageMagick via configure? I get a build failure during compilation. Here is attached the log. Created attachment 799129 [details]
build_failure_imagemagick.log.gz
This has been a headache forever: https://savannah.gnu.org/bugs/?func=detailitem&item_id=49653 I'm wondering if we shouldn't just require graphicsmagick (behind a USE flag?), since that seems to be all that gets tested. (In reply to Fabio Rossi from comment #3) > Created attachment 799129 [details] > build_failure_imagemagick.log.gz Would you mind reporting this failure upstream and linking it here? (In reply to Sam James from comment #5) > (In reply to Fabio Rossi from comment #3) > > Created attachment 799129 [details] > > build_failure_imagemagick.log.gz > > Would you mind reporting this failure upstream and linking it here? done, put the link in the URL field. I have checked again with latest octave 7.3.0. upstream introduced a commit to disable the magick support if imagemagick 7 is detected at configure time, from the bug report it doesn't seem they will introduce additional changes to make octave work also with imagemagick. If nobody steps in to produce a patch I think in gentoo would be better to depend only on graphicsmagick (maybe with a conditional useflag) (In reply to Fabio Rossi from comment #7) > upstream introduced a commit to disable the magick support if imagemagick 7 > is detected at configure time, from the bug report it doesn't seem they will > introduce additional changes to make octave work also with imagemagick. > > If nobody steps in to produce a patch I think in gentoo would be better to > depend only on graphicsmagick (maybe with a conditional useflag) I'm doing a @world update at the moment, but if no one objects, I'll do this as soon as my system becomes usable again. The names and descriptions of our global "graphicsmagick" and "imagemagick" USE flags are a bit unfortunate here. It looks like the best choice is to hide the dependency behind USE=imagemagick only, but then have it pull in media-gfx/graphicsmagick instead. (In reply to Michael Orlitzky from comment #8) > The names and descriptions of our global "graphicsmagick" and "imagemagick" > USE flags are a bit unfortunate here. It looks like the best choice is to > hide the dependency behind USE=imagemagick only, but then have it pull in > media-gfx/graphicsmagick instead. If I am correct, the dep should be behind USE=graphicsmagick, something like DEPEND+="graphicsmagick? ( media-gfx/graphicsmagick )" and $(use_with graphicsmagick magick GraphicsMagick++) in configure phase to avoid picking up imagemagick when graphicsmagick is not installed as happened to me initially. (In reply to Fabio Rossi from comment #9) > > If I am correct, the dep should be behind USE=graphicsmagick, something like > > DEPEND+="graphicsmagick? ( media-gfx/graphicsmagick )" > > and $(use_with graphicsmagick magick GraphicsMagick++) in configure phase to > avoid picking up imagemagick when graphicsmagick is not installed as > happened to me initially. That would make the most sense in isolation, but the global description of USE=graphicsmagick is, graphicsmagick - Build and link against GraphicsMagick instead of ImageMagick (requires USE=imagemagick if optional) While testing I noticed that the fltk/opengl backend doesn't seem to work on its own. It is successfully found by ./configure with the right *FLAGS, but:
octave:1> available_graphics_toolkits
ans = {}(1x0)
I've asked about this in #octave. If it's not supposed to work without the GUI, I may take this opportunity to merge USE=opengl into USE=gui and drop the fltk support entirely, since Qt provides its own widgets to display plots.
(In reply to Michael Orlitzky from comment #11) > While testing I noticed that the fltk/opengl backend doesn't seem to work on > its own. PEBKAC, it also needs --with-x. I've added a REQUIRED_USE for it. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff61ef7d2434eebfec1e13e04f5d7e92b2c1772d commit ff61ef7d2434eebfec1e13e04f5d7e92b2c1772d Author: Michael Orlitzky <mjo@gentoo.org> AuthorDate: 2022-11-09 17:58:19 +0000 Commit: Michael Orlitzky <mjo@gentoo.org> CommitDate: 2022-11-09 18:19:36 +0000 sci-mathematics/octave: new revision fixing some dependency issues. This revision adds a new flag, USE=imagemagick, to pull in media-gfx/graphicsmagick. That's not a typo -- the global USE flag descriptions for "imagemagick" and "graphicsmagick" make this awkward. In any case, Octave upstream doesn't really support imagemagick, only graphicsmagick. Thanks to Fabio Rossi for reporting the issue and suggesting the fix. Furthermore, 1. media-gfx/graphicsmagick was moved to DEPEND because Octave links with it. 2. The "static-libs" USE flag was dropped. 3. A new flag, USE=fltk, was factored out of USE=opengl. The Qt GUI can make use of OpenGL on its own. 4. An old hack for linking with fltk was dropped. 5. A new REQUIRED_USE prevents some nonsense combinations of the X, gui, fltk, and opengl USE flags. 6. Local descriptions for the fltk, gnuplot, and imagemagick flags were added to metadata.xml to explain more accurately what they actually do. Closes: https://bugs.gentoo.org/864785 Signed-off-by: Michael Orlitzky <mjo@gentoo.org> sci-mathematics/octave/metadata.xml | 3 ++ ...{octave-7.3.0.ebuild => octave-7.3.0-r1.ebuild} | 46 ++++++++++++++++------ 2 files changed, 38 insertions(+), 11 deletions(-) |
