Bug 863617

Summary:	sci-misc/boinc-7.20.2-r2: unnecessary dependencies on specific opencl implementations
Product:	Gentoo Linux	Reporter:	Craig Andrews <candrews>
Component:	Current packages	Assignee:	Gentoo Science Related Packages <sci>
Status:	RESOLVED FIXED
Severity:	normal	CC:	candrews, sven.eden
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/26737
Whiteboard:
Package list:		Runtime testing required:	---

Description Craig Andrews gentoo-dev

2022-08-04 14:04:20 UTC

The ebuilds states:
	opencl? (
		virtual/opencl
		video_cards_amdgpu?   ( amd64? ( dev-libs/rocm-opencl-runtime ) )
		video_cards_intel?    ( amd64? ( dev-libs/intel-compute-runtime ) )
		video_cards_nvidia?   ( x11-drivers/nvidia-drivers )
		video_cards_radeonsi? ( media-libs/mesa[opencl] )
	)

https://github.com/gentoo/gentoo/blob/c107ea718ccf7c064567904731462692d78cbd47/sci-misc/boinc/boinc-7.20.2-r2.ebuild#L50

I don't think there should be dependencies on the specific opencl implementations. No other packages in Gentoo have such dependencies.

virtual/opencl tells users that they must install a runtime... packages shouldn't also redundantly tell users to do so (or try it do it for them via dependencies):
https://github.com/gentoo/gentoo/blob/c107ea718ccf7c064567904731462692d78cbd47/virtual/opencl/opencl-3-r2.ebuild#L17

Reproducible: Always

Comment 1 Larry the Git Cow gentoo-dev

2022-08-09 13:12:07 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb1388ddcba362863ab793817e54f67fbe1e3c85

commit bb1388ddcba362863ab793817e54f67fbe1e3c85
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2022-08-04 14:07:21 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2022-08-09 13:11:59 +0000

    sci-misc/boinc: remove VIDEO_CARDS USE flag
    
    Closes: https://bugs.gentoo.org/863617
    Signed-off-by: Craig Andrews <candrews@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/26737
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 sci-misc/boinc/boinc-7.20.2-r3.ebuild | 196 ++++++++++++++++++++++++++++++++++
 sci-misc/boinc/boinc-9999.ebuild      |  15 +--
 2 files changed, 197 insertions(+), 14 deletions(-)