Bug 863524

Summary:	sys-apps/apparmor-3.0.4 fails to compile (lto): parser_yacc.h:163:7: error: type [-Werror=odr]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	The Gentoo Linux Hardened Team <hardened>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hardened
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=887475 https://gitlab.com/apparmor/apparmor/-/issues/214
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-08-04 06:56:00 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/apparmor-3.0.4 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

Comment 1 Agostino Sarubbo gentoo-dev

2022-08-04 06:56:03 UTC

Created attachment 797416 [details]
build.log

build log and emerge --info

Comment 2 Sam James archtester

2022-12-20 19:31:37 UTC

*** Bug 879889 has been marked as a duplicate of this bug. ***

Comment 3 Sam James archtester

2024-03-15 02:41:37 UTC

This seems to have been reported at https://gitlab.com/apparmor/apparmor/-/issues/214#note_832826723 and either got lost, or they concluded -flto-partition=1 was an acceptable workaround.

Comment 4 Larry the Git Cow gentoo-dev

2024-03-15 02:45:08 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=138b6134d1d4aa11a85ca2004b9fe886e52f7398

commit 138b6134d1d4aa11a85ca2004b9fe886e52f7398
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-15 02:43:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-15 02:43:40 +0000

    sys-apps/apparmor: filter LTO
    
    ODR violations. Seems to be worked around upstream with partitioning...
    
    Closes: https://bugs.gentoo.org/863524
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/apparmor/apparmor-3.0.10.ebuild | 9 ++++++++-
 sys-apps/apparmor/apparmor-3.0.8.ebuild  | 9 ++++++++-
 sys-apps/apparmor/apparmor-3.1.4.ebuild  | 9 ++++++++-
 3 files changed, 24 insertions(+), 3 deletions(-)