Bug 862990

Summary:	sci-libs/volk-2.5.0 installs stray .pyc files
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Rick Farina (Zero_Chaos) <zerochaos>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-08-02 10:24:38 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/volk-2.5.0 installs compiled Python modules that do not match installed modules.
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

Comment 1 Agostino Sarubbo gentoo-dev

2022-08-02 10:24:40 UTC

Created attachment 796840 [details]
build.log

build log and emerge --info

Comment 2 Rick Farina (Zero_Chaos) gentoo-dev

2022-08-09 22:28:47 UTC

What is the correct way to deal with something like this (usually)?  A find/rm to remove pyc/pyo before python_optimize?

Comment 3 Sam James archtester

2022-08-09 22:57:38 UTC

(In reply to Rick Farina (Zero_Chaos) from comment #2)
> What is the correct way to deal with something like this (usually)?  A
> find/rm to remove pyc/pyo before python_optimize?

> * For more information on bytecode files and related issues, please see:
> *   https://projects.gentoo.org/python/guide/qawarn.html#compiled-bytecode-related-warnings

-> https://projects.gentoo.org/python/guide/qawarn.html#stray-compiled-bytecode

Comment 4 Larry the Git Cow gentoo-dev

2022-09-02 16:37:30 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e37308a9795570c15334f65eef34a22d0fae2202

commit e37308a9795570c15334f65eef34a22d0fae2202
Author:     Rick Farina <zerochaos@gentoo.org>
AuthorDate: 2022-09-02 16:36:40 +0000
Commit:     Rick Farina <zerochaos@gentoo.org>
CommitDate: 2022-09-02 16:36:45 +0000

    sci-libs/volk: add 2.5.1
    
    Signed-off-by: Rick Farina <zerochaos@gentoo.org>
    Remove stray pyc/pyo files
    Closes: https://bugs.gentoo.org/862990

 sci-libs/volk/Manifest          |  1 +
 sci-libs/volk/volk-2.5.1.ebuild | 48 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+)