Bug 862849 – [guru] gui-apps/swaync-0.6.3-r1 fails to compile (lto): error: Package GtkLayerShell-0.1 not found in specified Vala API directories or GObject-Introspection GIR directories

• Product: GURU
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-08-01 17:44:04 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: gui-apps/swaync-0.6.3-r1 fails to compile (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-08-01 17:44:07 UTC]

Created attachment 796660 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-08-01 17:44:08 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: src/swaync-client.p/client.c src/swaync-client.p/constants.c 
FAILED: src/swaync.p/main.c src/swaync.p/configModel/configModel.c src/swaync.p/swayncDaemon/swayncDaemon.c src/swaync.p/notiDaemon/notiDaemon.c src/swaync.p/notiModel/notiModel.c src/swaync.p/notificationWindow/notificationWindow.c src/swaync.p/notification/notification.c src/swaync.p/controlCenter/controlCenter.c src/swaync.p/controlCenter/topAction/topAction.c src/swaync.p/blankWindow/blankWindow.c src/swaync.p/functions.c src/swaync.p/constants.c 
Run-time dependency fish found: NO (tried pkgconfig and cmake)
Run-time dependency systemd found: NO (tried pkgconfig and cmake)
error: Package `GtkLayerShell-0.1' not found in specified Vala API directories or GObject-Introspection GIR directories

[Comment 3 Joe Kappus 2022-09-20 10:33:51 UTC]

Need to modify DEPEND:

        >=gui-libs/gtk-layer-shell-0.6.0

to

        >=gui-libs/gtk-layer-shell-0.6.0[introspection]


Then it will build successfully. I will commit the change to dev once I have been granted access.

[Comment 4 Joe Kappus 2022-09-21 22:42:32 UTC]

Fixed in dev branch before I could get back to this.