Bug 862510 – [guru] dev-python/sphinxcontrib-restbuilder-0.3 fails tests (lto)

• Product: GURU
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-07-31 10:57:53 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-python/sphinxcontrib-restbuilder-0.3 fails tests (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-07-31 10:57:57 UTC]

Created attachment 796111 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

[Comment 2 Agostino Sarubbo 2022-07-31 10:57:58 UTC]

Error(s) that match a know pattern:


                except KeyError:
                except OSError:
            except AttributeError:
            except OSError:
            except UnicodeError:
E               sphinx.errors.ExtensionError: Could not import extension sphinx.builders.epub3 (exception: No module named 'sphinxcontrib.serializinghtml')
E   ModuleNotFoundError: No module named 'sphinxcontrib.serializinghtml'
FAILED tests/test_rst_blocks.py::test_indentation - sphinx.errors.ExtensionEr...
FAILED tests/test_rst_blocks.py::test_literal_block - sphinx.errors.Extension...
FAILED tests/test_rst_blocks.py::test_paragraph - sphinx.errors.ExtensionErro...
FAILED tests/test_rst_code_blocks.py::test_code - sphinx.errors.ExtensionErro...
FAILED tests/test_rst_code_blocks.py::test_code_block - sphinx.errors.Extensi...
FAILED tests/test_rst_code_blocks.py::test_code_block_language - sphinx.error...
FAILED tests/test_rst_code_blocks.py::test_code_block_linenos - sphinx.errors...
FAILED tests/test_rst_code_blocks.py::test_code_language - sphinx.errors.Exte...
FAILED tests/test_rst_code_blocks.py::test_code_number_lines - sphinx.errors....
FAILED tests/test_rst_formatting.py::test_bold - sphinx.errors.ExtensionError...
FAILED tests/test_rst_formatting.py::test_italic - sphinx.errors.ExtensionErr...
FAILED tests/test_rst_formatting.py::test_literal - sphinx.errors.ExtensionEr...
FAILED tests/test_rst_formatting.py::test_smart_quotes - sphinx.errors.Extens...
FAILED tests/test_rst_formatting.py::test_subscript - sphinx.errors.Extension...
FAILED tests/test_rst_formatting.py::test_superscript - sphinx.errors.Extensi...
FAILED tests/test_rst_headings.py::test_headings - sphinx.errors.ExtensionErr...
FAILED tests/test_rst_hyperlinks.py::test_cross_ref - sphinx.errors.Extension...
FAILED tests/test_rst_hyperlinks.py::test_doc_role - sphinx.errors.ExtensionE...
FAILED tests/test_rst_hyperlinks.py::test_external_hyperlinks - sphinx.errors...
FAILED tests/test_rst_hyperlinks.py::test_hyperlink_targets - sphinx.errors.E...
FAILED tests/test_rst_hyperlinks.py::test_internal_hyperlinks - sphinx.errors...
FAILED tests/test_rst_hyperlinks.py::test_nonexisting_target - sphinx.errors....
FAILED tests/test_rst_hyperlinks.py::test_ref - sphinx.errors.ExtensionError:...
FAILED tests/test_rst_list.py::test_bullet_list - sphinx.errors.ExtensionErro...
FAILED tests/test_rst_list.py::test_definition_list - sphinx.errors.Extension...
FAILED tests/test_rst_list.py::test_multiline_list - sphinx.errors.ExtensionE...
FAILED tests/test_rst_list.py::test_nested_list - sphinx.errors.ExtensionErro...
FAILED tests/test_rst_list.py::test_ordered_list - sphinx.errors.ExtensionErr...
FAILED tests/test_rst_table.py::test_grid_table - sphinx.errors.ExtensionErro...
FAILED tests/test_rst_table.py::test_list_table - sphinx.errors.ExtensionErro...
FAILED tests/test_rst_table.py::test_simple_table - sphinx.errors.ExtensionEr...
FAILED tests/test_rst_toctree.py::test_toctree - sphinx.errors.ExtensionError...
FAILED tests/test_sphinx_versionmodified.py::test_deprecated - sphinx.errors....
FAILED tests/test_sphinx_versionmodified.py::test_versionadded - sphinx.error...
FAILED tests/test_sphinx_versionmodified.py::test_versionchanged - sphinx.err...
            def onerror(filename: str, error: Exception) -> None:

[Comment 3 Larry the Git Cow 2023-02-27 15:06:47 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=fa2947acde938b1d61979050f2b53a77d182d517

commit fa2947acde938b1d61979050f2b53a77d182d517
Author:     Anna (cybertailor) Vyalkova <[e-mail]>
AuthorDate: 2023-02-26 23:44:47 +0000
Commit:     Anna (cybertailor) Vyalkova <[e-mail]>
CommitDate: 2023-02-26 23:44:47 +0000

    dev-python/sphinxcontrib-restbuilder: enable py3.11, fix tests
    
    Closes: https://bugs.gentoo.org/862510
    Closes: https://bugs.gentoo.org/897576
    Signed-off-by: Anna (cybertailor) Vyalkova <[e-mail]>

 dev-python/sphinxcontrib-restbuilder/Manifest      |  2 +-
 .../sphinxcontrib-restbuilder-0.3-r1.ebuild        | 39 ++++++++++++++++++++++
 .../sphinxcontrib-restbuilder-0.3.ebuild           | 29 ----------------
 3 files changed, 40 insertions(+), 30 deletions(-)