Bug 862477 – [guru] dev-python/python-vitrageclient-4.5.0 fails tests (lto)

• Product: GURU
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-07-31 07:39:46 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-python/python-vitrageclient-4.5.0 fails tests (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-07-31 07:39:48 UTC]

Created attachment 796003 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-07-31 07:39:49 UTC]

Error(s) that match a know pattern:


FAILED vitrageclient/tests/cli/test_topology_show.py::TopologyShowTest::test_dot_emitter
ValueError: Node names and attributes should not contain ":" unless they are quoted with "".                For example the string 'attribute:data1' should be written as '"attribute:data1"'.                Please refer https://github.com/pydot/pydot/issues/258

[Comment 3 Larry the Git Cow 2023-02-27 15:06:43 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=3e9081da28d4070d0796840f7675bd6df2fd19c6

commit 3e9081da28d4070d0796840f7675bd6df2fd19c6
Author:     Anna (cybertailor) Vyalkova <[e-mail]>
AuthorDate: 2023-02-26 19:05:19 +0000
Commit:     Anna (cybertailor) Vyalkova <[e-mail]>
CommitDate: 2023-02-26 22:41:34 +0000

    profiles: start masking libs with no consumers
    
    Closes: https://bugs.gentoo.org/848552
    Closes: https://bugs.gentoo.org/862474
    Closes: https://bugs.gentoo.org/862477
    Signed-off-by: Anna (cybertailor) Vyalkova <[e-mail]>

 profiles/package.mask | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)