Bug 862444 – sci-libs/votca-tools-2021.2 fails to compile (lto): tokenizer.h:110:8: error: unique_ptr in namespace std does not name a template type

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-07-31 07:29:49 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/votca-tools-2021.2 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-07-31 07:29:52 UTC]

Created attachment 795970 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-07-31 07:29:54 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: src/libtools/CMakeFiles/votca_tools.dir/correlate.cc.o 
FAILED: src/libtools/CMakeFiles/votca_tools.dir/crosscorrelate.cc.o 
FAILED: src/libtools/CMakeFiles/votca_tools.dir/datacollection.cc.o 
FAILED: src/libtools/CMakeFiles/votca_tools.dir/histogram.cc.o 
/var/tmp/portage/sci-libs/votca-tools-2021.2/work/tools-2021.2/include/votca/tools/tokenizer.h:110:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type

[Comment 3 Larry the Git Cow 2023-01-27 11:11:34 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc710ddaba2239a33051320409b1e700acdb385b

commit fc710ddaba2239a33051320409b1e700acdb385b
Author:     Jakov Smolić <[e-mail]>
AuthorDate: 2023-01-27 10:48:26 +0000
Commit:     Jakov Smolić <[e-mail]>
CommitDate: 2023-01-27 11:07:06 +0000

    sci-libs/votca-tools: treeclean
    
    Closes: https://bugs.gentoo.org/841830
    Closes: https://bugs.gentoo.org/862444
    Signed-off-by: Jakov Smolić <[e-mail]>

 profiles/package.mask                          |  1 -
 sci-libs/votca-tools/Manifest                  |  2 --
 sci-libs/votca-tools/metadata.xml              | 15 ---------
 sci-libs/votca-tools/votca-tools-1.6.4.ebuild  | 43 ------------------------
 sci-libs/votca-tools/votca-tools-2021.2.ebuild | 45 --------------------------
 5 files changed, 106 deletions(-)