Bug 862270 – sci-biology/glimmerhmm-3.0.1-r1 fails to compile (lto): oc1.h:52:6: error: [-Werror=odr]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-07-30 08:29:56 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-biology/glimmerhmm-3.0.1-r1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-07-30 08:29:58 UTC]

Created attachment 795754 [details]
build.log

build log and emerge --info

[Comment 2 Larry the Git Cow 2024-03-12 06:22:19 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=224d5e9ecdba92cf4e9e7515056dcad158cbafbd

commit 224d5e9ecdba92cf4e9e7515056dcad158cbafbd
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-03-12 05:50:56 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-12 06:14:20 +0000

    sci-biology/glimmerhmm: patch sources to fix LTO
    
    Upstream last released in 2015. I don't have high hopes for a change but
    I sent an email to the contact address. ;)
    
    Closes: https://bugs.gentoo.org/862270
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 .../files/0001-fix-ridiculous-ODR-violation.patch  | 27 ++++++++++++++++++++++
 sci-biology/glimmerhmm/glimmerhmm-3.0.1-r1.ebuild  |  3 ++-
 2 files changed, 29 insertions(+), 1 deletion(-)