Bug 861635

Summary:	[guru] app-misc/ntfy-2.7.0 fails tests (lto)
Product:	GURU	Reporter:	Agostino Sarubbo <ago>
Component:	Package issues	Assignee:	David Roman <davidroman96>
Status:	RESOLVED OBSOLETE
Severity:	normal	CC:	guru-bugs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-07-28 07:13:52 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-misc/ntfy-2.7.0 fails tests (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

Comment 1 Agostino Sarubbo gentoo-dev

2022-07-28 07:13:55 UTC

Created attachment 795140 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2022-07-28 07:13:56 UTC

Error(s) that match a know pattern:


E               TypeError: emojize() got an unexpected keyword argument 'use_aliases'
FAILED tests/test_cli.py::TestMain::test_args - TypeError: emojize() got an u...
FAILED tests/test_integration.py::TestIntegration::test_darwin - TypeError: e...
FAILED tests/test_integration.py::TestIntegration::test_default - TypeError: ...
FAILED tests/test_integration.py::TestIntegration::test_instapush - TypeError...
FAILED tests/test_integration.py::TestIntegration::test_linux - TypeError: em...
FAILED tests/test_integration.py::TestIntegration::test_prowl - TypeError: em...
FAILED tests/test_integration.py::TestIntegration::test_pushbullet - TypeErro...
FAILED tests/test_integration.py::TestIntegration::test_pushover - TypeError:...
FAILED tests/test_integration.py::TestIntegration::test_simplepush - TypeErro...
FAILED tests/test_integration.py::TestIntegration::test_win32 - TypeError: em...

Comment 3 David Roman 2023-07-13 10:36:04 UTC

This ebuild was removed in commit 5d9a04ac6ed7050bcf2ee2cb372067ed263fc4f7

No new releases since 2018