Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 861605

Summary: net-misc/dahdi-tools-3.1.0-r4 fails to compile (lto): <artificial>:(.text+0x536b): undefined reference to get_ver
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Jaco Kroon <jaco>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/30996
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 618550    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-07-28 06:57:49 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/dahdi-tools-3.1.0-r4 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-28 06:57:52 UTC
Created attachment 795107 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-28 06:57:53 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


<artificial>:(.text+0x536b): undefined reference to `get_ver'
<artificial>:(.text.startup+0x10a1): undefined reference to `get_ver'
sed: can't read conftest.c: No such file or directory
collect2: error: ld returned 1 exit status
Comment 3 Larry the Git Cow gentoo-dev 2023-05-12 03:53:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=84ba723adca728dfcaa2cb0f19112e51cbb22518

commit 84ba723adca728dfcaa2cb0f19112e51cbb22518
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2023-05-11 15:37:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-12 03:53:42 +0000

    net-misc/dahdi-tools: add 3.2.0
    
    Closes: https://bugs.gentoo.org/861605
    Closes: https://bugs.gentoo.org/873766
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://github.com/gentoo/gentoo/pull/30996
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/dahdi-tools/Manifest                      |  1 +
 net-misc/dahdi-tools/dahdi-tools-3.2.0.ebuild      | 73 ++++++++++++++++++++++
 .../dahdi-tools/files/dahdi-tools-3.2.0-lto.patch  | 61 ++++++++++++++++++
 net-misc/dahdi-tools/metadata.xml                  |  3 +
 4 files changed, 138 insertions(+)