Bug 861581

Summary:	net-libs/rtrlib-0.8.0 fails to compile (lto): test_pfx.c:132:54: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	eschwartz
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/rtrlib/rtrlib/issues/287
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-07-28 06:51:07 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/rtrlib-0.8.0 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

Comment 1 Agostino Sarubbo gentoo-dev

2022-07-28 06:51:10 UTC

Created attachment 795083 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2022-07-28 06:51:12 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: tests/CMakeFiles/test_pfx.dir/test_pfx.c.o 
/var/tmp/portage/net-libs/rtrlib-0.8.0/work/rtrlib-0.8.0/tests/test_pfx.c:132:54: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]

Comment 3 Larry the Git Cow gentoo-dev

2024-03-05 04:48:45 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d58f870d7043f3891c0fd707bd55c912368b9486

commit d58f870d7043f3891c0fd707bd55c912368b9486
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-05 04:20:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-05 04:47:53 +0000

    net-libs/rtrlib: mark as LTO-unsafe, strict-aliasing unsafe
    
    Closes: https://bugs.gentoo.org/861581
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/rtrlib/rtrlib-0.8.0.ebuild | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)