Bug 861386 – net-im/element-desktop-bin-1.11.8-r1 does not respect LDFLAGS

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-07-27 06:53:32 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-im/element-desktop-bin-1.11.0 does not respect LDFLAGS.
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
To reproduce this issue you may want to set LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ context you may want to see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect LDFLAGS.

[Comment 1 Agostino Sarubbo 2022-07-27 06:53:34 UTC]

Created attachment 794714 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-07-29 06:48:32 UTC]

ci has reproduced this issue with version 1.11.1 - Updating summary.

[Comment 3 Agostino Sarubbo 2022-09-29 06:36:57 UTC]

ci has reproduced this issue with version 1.11.8 - Updating summary.

[Comment 4 Agostino Sarubbo 2022-10-06 06:46:51 UTC]

ci has reproduced this issue with version 1.11.8-r1 - Updating summary.

[Comment 5 Larry the Git Cow 2022-10-08 23:08:27 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95c3b965332b174e0ce24aca3e6048bafe36d773

commit 95c3b965332b174e0ce24aca3e6048bafe36d773
Author:     Ronny (tastytea) Gutbrod <[e-mail]>
AuthorDate: 2022-09-29 11:59:03 +0000
Commit:     Stefan Strogin <[e-mail]>
CommitDate: 2022-10-08 23:05:18 +0000

    net-im/element-desktop-bin: update SRC_URI, add files to QA_PREBUILT
    
    The Debian repo changed from packages.riot.im to packages.element.io,
    the files are the same.
    <https://element.io/get-started#linux-details>
    
    Closes: https://bugs.gentoo.org/861386
    Closes: https://bugs.gentoo.org/861821
    Signed-off-by: Ronny (tastytea) Gutbrod <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/27525
    Signed-off-by: Stefan Strogin <[e-mail]>

 net-im/element-desktop-bin/element-desktop-bin-1.11.8-r1.ebuild | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)