Bug 859997 – [guru] games-fps/openspades-0.1.3 fails to compile (lto): as_config.h:1237:23: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]

• Product: GURU
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-07-22 07:41:53 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-fps/openspades-0.1.3 fails to compile (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

[Comment 1 Agostino Sarubbo 2022-07-22 07:41:56 UTC]

Created attachment 793085 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-07-22 07:41:57 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: Sources/AngelScript/projects/cmake/CMakeFiles/Angelscript.dir/__/__/source/as_builder.cpp.o 
FAILED: Sources/AngelScript/projects/cmake/CMakeFiles/Angelscript.dir/__/__/source/as_bytecode.cpp.o 
/var/tmp/portage/games-fps/openspades-0.1.3/work/openspades-0.1.3/Sources/AngelScript/source/as_config.h:1237:23: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]

[Comment 3 Agostino Sarubbo 2022-07-26 09:08:51 UTC]

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 4 Larry the Git Cow 2022-08-02 10:55:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=993172f9951b4ccda8e3a1eb73fc0df9ed7872aa

commit 993172f9951b4ccda8e3a1eb73fc0df9ed7872aa
Author:     Duje Mihanović <[e-mail]>
AuthorDate: 2022-07-25 10:16:23 +0000
Commit:     Duje Mihanović <[e-mail]>
CommitDate: 2022-07-25 10:16:23 +0000

    games-fps/openspades: add -fno-strict-aliasing
    
    Closes: https://bugs.gentoo.org/859997
    Signed-off-by: Duje Mihanović <[e-mail]>

 games-fps/openspades/openspades-0.1.3.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)