| Summary: | [guru] games-engines/fs2_open-22.0.0 fails to compile (lto): barracks.cpp:188: error: type struct barracks_buttons violates the C++ One Definition Rule [-Werror=odr] | ||
|---|---|---|---|
| Product: | GURU | Reporter: | Agostino Sarubbo <ago> |
| Component: | Package issues | Assignee: | GURU project <guru-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | guru-bugs |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | build.log.xz | ||
|
Description
Agostino Sarubbo
2022-07-22 07:35:28 UTC
Created attachment 793070 [details]
build.log.xz
build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: -- Could NOT find ANTLR (missing: ANTLR_EXECUTABLE Java_JAVA_EXECUTABLE) -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) FAILED: bin/fs2_open_22_0_0 /var/tmp/portage/games-engines/fs2_open-22.0.0/work/fs2open.github.com-release_22_0_0/code/menuui/barracks.cpp:188: error: type ‘struct barracks_buttons’ violates the C++ One Definition Rule [-Werror=odr] I have no idea what's causing this bug or how to solve it. Maybe someone with more experience can take a look... (In reply to Jonas Frei from comment #3) > I have no idea what's causing this bug or how to solve it. Maybe someone > with more experience can take a look... A bug needs to be filed upstream for the -Werror=odr violations. Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=b7af427658d58502ae043866a3ab4d716c15f0e8 commit b7af427658d58502ae043866a3ab4d716c15f0e8 Author: Takuya Wakazono <pastalian46@gmail.com> AuthorDate: 2024-11-09 06:14:48 +0000 Commit: Takuya Wakazono <pastalian46@gmail.com> CommitDate: 2024-11-09 08:24:47 +0000 games-engines/fs2_open: fix ODR violations and DEPEND Closes: https://bugs.gentoo.org/859982 Closes: https://bugs.gentoo.org/917418 Closes: https://bugs.gentoo.org/935326 Signed-off-by: Takuya Wakazono <pastalian46@gmail.com> .../fs2_open/files/fs2_open-24.0.2-fix-odr.patch | 173 +++++++++++++++++++++ .../files/fs2_open-24.0.2-respect-flags.patch | 83 ++++++++++ ...pen-24.0.2.ebuild => fs2_open-24.0.2-r1.ebuild} | 20 ++- 3 files changed, 269 insertions(+), 7 deletions(-) |
