Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 859862

Summary: media-libs/assimp-5.2.4 installs pkg-config files with mismatched Version
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Bernd <waebbl-gentoo>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/assimp/assimp/issues/4655
https://github.com/gentoo/gentoo/pull/26566
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 857654    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-07-21 20:09:47 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/assimp-5.2.4 installs pkg-config files with mismatched Version.
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-21 20:09:50 UTC
Created attachment 792956 [details]
build.log

build log and emerge --info
Comment 2 Bernd 2022-07-24 14:34:16 UTC
This also affects the cmake file(s).
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-23 00:47:08 UTC
See https://bugs.gentoo.org/857654#c1. This check has been dropped in portage-3.0.35 because of false positives, usually relating to SONAME versioning not corresponding to ${PV}.

It may be restored at a later time in an opt-in fashion (either for users/developers to set in e.g. make.conf, or for ebuilds to enable when upstream is known to make errors (possibly could be by setting QA_PKGCONFIG_VERSION?)).

Apologies for the noise until now. It was an experiment and while some legitimate bugs were found, it was too noisy and that's unfair to developers.
Comment 4 Bernd 2022-08-23 05:06:30 UTC
@Sam, this is one of the legitimate bugs you mention. It's been fixed upstream, and there's a PR open already, so should this bug on the issue not stay open and closed by merging the PR?
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-23 05:09:08 UTC
(In reply to Bernd from comment #4)
> @Sam, this is one of the legitimate bugs you mention. It's been fixed
> upstream, and there's a PR open already, so should this bug on the issue not
> stay open and closed by merging the PR?

Totally ok to reopen & merge the PR. Sorry, I just had to do the closure en-masse.
Comment 6 Larry the Git Cow gentoo-dev 2022-08-23 05:11:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=586bd49181ad3b91291ac4d9bdd05f70b7dc2dce

commit 586bd49181ad3b91291ac4d9bdd05f70b7dc2dce
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2022-07-24 14:33:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-23 05:10:55 +0000

    media-libs/assimp: fix version mismatch in pkg-config and cmake files
    
    Closes: https://bugs.gentoo.org/859862
    Bug: https://github.com/assimp/assimp/issues/4655
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Closes: https://github.com/gentoo/gentoo/pull/26566
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/assimp/assimp-5.2.4-r1.ebuild           | 67 ++++++++++++++++++++++
 .../assimp/files/assimp-5.2.4-update-version.patch | 34 +++++++++++
 2 files changed, 101 insertions(+)