Bug 859826 – media-libs/ampache_browser-1.0.3 fails to compile (lto): ampache_browser_main_window.h:31:7: error: type struct AmpacheBrowserMainWindow violates the C++ One Definition Rule [-Werror=odr]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-07-21 19:56:45 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/ampache_browser-1.0.3 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

[Comment 1 Agostino Sarubbo 2022-07-21 19:56:47 UTC]

Created attachment 792917 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-07-21 19:56:50 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: libampache_browser_1.so.0.0.3 
/var/tmp/portage/media-libs/ampache_browser-1.0.3/work/ampache_browser-1.0.3/src/ui/ampache_browser_main_window.h:31:7: error: type ‘struct AmpacheBrowserMainWindow’ violates the C++ One Definition Rule [-Werror=odr]

[Comment 3 Agostino Sarubbo 2022-07-26 09:02:18 UTC]

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 4 Róbert Čerňanský 2022-07-26 10:37:28 UTC]

I have fixed the issue in upstream and created a pull request which adds the new version (1.0.4) (https://github.com/gentoo/gentoo/pull/26590).  After a stabilization period 1.0.4 will be stabilized and 1.0.3 removed.

[Comment 5 Larry the Git Cow 2022-08-04 07:12:31 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c82ab3db6c4955d111f95fa860766e123d93ddb7

commit c82ab3db6c4955d111f95fa860766e123d93ddb7
Author:     Róbert Čerňanský <[e-mail]>
AuthorDate: 2022-07-25 16:03:38 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2022-08-04 07:07:15 +0000

    media-libs/ampache_browser: add 1.0.4 which builds with -flto
    
    Bug: https://bugs.gentoo.org/859826
    Signed-off-by: Róbert Čerňanský <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/26590
    Signed-off-by: Joonas Niilola <[e-mail]>

 media-libs/ampache_browser/Manifest                |  1 +
 .../ampache_browser/ampache_browser-1.0.4.ebuild   | 28 ++++++++++++++++++++++
 2 files changed, 29 insertions(+)

[Comment 6 Larry the Git Cow 2022-08-30 16:08:39 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab12fd4ab62e2eba175701460e40610d34c30aae

commit ab12fd4ab62e2eba175701460e40610d34c30aae
Author:     Róbert Čerňanský <[e-mail]>
AuthorDate: 2022-08-30 09:31:32 +0000
Commit:     Arthur Zamarin <[e-mail]>
CommitDate: 2022-08-30 16:08:13 +0000

    media-libs/ampache_browser: Remove old ebuild
    
    Closes: https://bugs.gentoo.org/859826
    Signed-off-by: Róbert Čerňanský <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/27068
    Signed-off-by: Arthur Zamarin <[e-mail]>

 media-libs/ampache_browser/Manifest                |  1 -
 .../ampache_browser/ampache_browser-1.0.3.ebuild   | 28 ----------------------
 2 files changed, 29 deletions(-)