Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 85964

Summary: media-video/gxine-0.4.1 small cleanups patch
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Chris White (RETIRED) <chriswhite>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: gxine-0.4.1.patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-19 18:47:43 UTC
The attached patch applied over current ebuild cleans it up a bit:

- it removes the X useflag (the configure options which was passed wasn't recognized by ./configure of gxine, gxine also depends on gtk so it needs X anyway)
- it enforces lirc useflag, which changed the dependencies but didn't actually enabled/disabled it.
- it changes the way the flags are passed to econf (directly using use_enable function instead of $myconf), it also adds --disable-dependency-tracking to speed it up a bit.
- it installs the icon as gxine.png into the hicolor structure, after renaming the icon in the .desktop file from gxine-logo.png to gxine, so that icon theme could replace it easily.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-19 18:48:41 UTC
Created attachment 53904 [details, diff]
gxine-0.4.1.patch
Comment 2 Chris White (RETIRED) gentoo-dev 2005-03-28 06:12:27 UTC
Closed here.