Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 859517

Summary: mail-filter/procmail-3.22-r15 fails to compile (lto): foldinfo.c:60:12: error: type of [-Werror=lto-type-mismatch]
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 618550    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-07-20 12:08:10 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: mail-filter/procmail-3.22-r15 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-20 12:08:12 UTC
Created attachment 792530 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 09:02:09 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 3 Larry the Git Cow gentoo-dev 2023-12-02 07:13:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e92325dddea86232ac9577049695a9f11522a58c

commit e92325dddea86232ac9577049695a9f11522a58c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-02 06:05:44 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-02 07:10:15 +0000

    mail-filter/procmail: update EAPI 6 -> 8, gnu89, no LTO
    
    * Filter LTO (bug #859517, bug #874375 - the latter is a somewhat real bug but
      it only happens with races and not worth fixing for procmail anyway given
      the first bug & it's dead)
    
    * Set -std=gnu89 (bug #875251, bug #896052) for modern C compilers.
    
    Closes: https://bugs.gentoo.org/859517
    Closes: https://bugs.gentoo.org/875251
    Closes: https://bugs.gentoo.org/896052
    Closes: https://bugs.gentoo.org/874375
    Signed-off-by: Sam James <sam@gentoo.org>

 mail-filter/procmail/procmail-3.22-r16.ebuild | 135 ++++++++++++++++++++++++++
 1 file changed, 135 insertions(+)