Bug 859277

Summary:	games-strategy/widelands-1.0 fails to compile with gcc12: editorinteractive.h:64:37: error: member EditorInteractive::Tools::unset_port_space is used uninitialized [-Werror=uninitialized]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, ionen
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867, 839906
Attachments:	build.log.xz

Description Agostino Sarubbo gentoo-dev

2022-07-19 09:27:59 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-strategy/widelands-1.0 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Comment 1 Agostino Sarubbo gentoo-dev

2022-07-19 09:28:01 UTC

Created attachment 792344 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

Comment 2 Agostino Sarubbo gentoo-dev

2022-07-19 09:28:03 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
FAILED: src/CMakeFiles/widelands_ball_of_mud.dir/wlapplication.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/editorinteractive.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/decrease_height_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/decrease_resources_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/delete_critter_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/delete_immovable_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/history.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/increase_height_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/increase_resources_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/info_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/noise_height_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/place_critter_tool.cc.o 
FAILED: src/editor/CMakeFiles/editor.dir/tools/place_immovable_tool.cc.o 
/var/tmp/portage/games-strategy/widelands-1.0/work/widelands-1.0/src/editor/editorinteractive.h:64:37: error: member ‘EditorInteractive::Tools::unset_port_space’ is used uninitialized [-Werror=uninitialized]

Comment 3 Larry the Git Cow gentoo-dev

2022-07-19 11:50:18 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f594b85a3282c5f399b1ca52cef3c27374d5392c

commit f594b85a3282c5f399b1ca52cef3c27374d5392c
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-07-19 11:01:10 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-07-19 11:49:12 +0000

    games-strategy/widelands: fix build with gcc-12
    
    Due to new gcc-12 warnings that die to -Werror=uninitialized,
    both adjust the variable and drop these -Werror= (upstream also
    disable -Werror with gcc-12 but for other reasons, see patch).
    
    Closes: https://bugs.gentoo.org/859277
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../files/widelands-1.0-gcc12-werror.patch         | 29 ++++++++++++++++++++++
 games-strategy/widelands/widelands-1.0.ebuild      |  1 +
 2 files changed, 30 insertions(+)