Bug 859157

Summary:	eclass/tests/toolchain.sh uses EAPI 5
Product:	Gentoo Linux	Reporter:	Ulrich Müller <ulm>
Component:	Eclasses	Assignee:	Gentoo Toolchain Maintainers <toolchain>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=934124 https://bugs.gentoo.org/show_bug.cgi?id=939817
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	698100

Description Ulrich Müller gentoo-dev

2022-07-18 19:08:21 UTC

The test script has EAPI=5 which is no longer supported by toolchain.eclass:

~/git/gentoo/eclass/tests $ ./toolchain.sh
die: : EAPI 5 not supported

After updating toolchain.sh to EAPI=7 (and adding an inherit for eapi7-ver), several other problems are reported:
- TOOLCHAIN_GCC_PV=7.3.0 appears to be too old
- multiple test failures related to downgrade_arch_flags

Comment 1 Larry the Git Cow gentoo-dev

2023-04-20 23:14:06 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=55074a1c37442d3dedf5e65dcb93c8e6d20c6af8

commit 55074a1c37442d3dedf5e65dcb93c8e6d20c6af8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-04-20 23:12:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-20 23:12:51 +0000

    eclass/tests: partially fix toolchain.eclass tests
    
    - Use the same hack as in crossdev for now wrt EAPI.
    - Fix up the version tests.
    
    We still need to investigate the issues with -march downgrading though.
    
    Bug: https://bugs.gentoo.org/859157
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/tests/toolchain.sh | 41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)

Comment 2 Larry the Git Cow gentoo-dev

2024-09-18 15:51:30 UTC Comment hidden (obsolete)

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f3bfeac6adc6b4e9db50b1204c1a398523c55b1

commit 3f3bfeac6adc6b4e9db50b1204c1a398523c55b1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-09-18 15:49:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-09-18 15:49:34 +0000

    Revert "eclass/tests/toolchain.sh: declare PYTHON_COMPAT"
    
    This reverts commit 992fc2954c2281285bc50156ba12d310a1b434e1.
    
    This should no longer be necessary now that tests are opt-in
    with TOOLCHAIN_HAS_TESTS.
    
    Bug: https://bugs.gentoo.org/859157
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/tests/toolchain.sh | 2 --
 1 file changed, 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=992fc2954c2281285bc50156ba12d310a1b434e1

commit 992fc2954c2281285bc50156ba12d310a1b434e1
Author:     Petr Vaněk <arkamar@gentoo.org>
AuthorDate: 2024-09-18 11:30:12 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-09-18 15:49:09 +0000

    eclass/tests/toolchain.sh: declare PYTHON_COMPAT
    
    toolchain.sh test script requires PYTHON_COMPAT array since commit
    1d93a491096f ("toolchain.eclass: rework tests more") otherwise it dies
    with
    
     die: PYTHON_COMPAT not declared.
    
    error.
    
    Bug: https://bugs.gentoo.org/859157
    Signed-off-by: Petr Vaněk <arkamar@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/tests/toolchain.sh | 2 ++
 1 file changed, 2 insertions(+)

Comment 3 Sam James archtester

2024-09-18 15:55:30 UTC

Ah, I added the wrong bug tag for those two. I meant bug 934124.

Comment 4 Sam James archtester

2024-09-18 15:56:15 UTC

Let's split the other stuff into its own bug.