Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 85900

Summary: dev-util/cssc version bump.
Product: Gentoo Linux Reporter: James Rowe <jnrowe>
Component: Current packagesAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: RESOLVED DUPLICATE    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description James Rowe 2005-03-19 06:45:49 UTC
Just a version bump to v1.0.1.  Note the ebuild with this patch _is_ broken,
but I can't see a way to fix it so I'm hoping for some input you, this bug's
reader, on how it should work.

  Firstly, the ebuild uses fixheadtails now just to clean up some current
warnings and hopefully stop errors with later versions of coreutils ;)

  I've not changed the src_compile()'s --enable-binary arg, even though it
seems quite pointless as it is the default behaviour.  Perhaps it is to stop
people reporting bugs :/

  src_install() now installs the full range of docs, and the example cgi
script for web based SCCS navigation.

  src_test() is the function causing the problems.  y-flag.sh should be an
XFAIL in my opinion(in as much as it is broken), so it is forcibly skipped
when the testsuite is run.

  The real cause of the problems is that "make check" will fail because it
/rightly/ checks the user who runs the testsuite is not root, if they are it
fails.  The reason being the nature of the SCCS tools means it needs to
check behaviour when files are read-only, and there is pretty much no such
thing to root which would mean it falsely fail some tests which should have
passed.

  The patch I've attached to this bug calls "su" to change the user to jay
on line 33, obviously this is broken but it is to illustrate the point(and
it allowed me to test the package on this box).  I'm not aware of any user
who could be used for this test on *all* systems, and this is where you come
in:  is there a user that is applicable for these types of tests[1]?

  Due to importance of validity tests for a package that actually holds your
data, I think disabling checks would be quite foolish.  It isn't like an
editor where errors might cost you your current work, in this case errors
could cost you your whole history.  That is just my opinion on the matter
though, and I'm sure others will think differently.

  Outside of the src_test() problems this new version of cssc brings a lot
of bug fixes which definitely warrant a quick bump, or somebody willing to
come down to my place of work and kick people who think we should still
support SCCS file formats.  If you are that person drop me a mail :P

1.  I'm incredibly sure this isn't the only instance of a package where such
a user is needed, but granted it is the only one I've found so far.
Thinking about it some more has made me start taking more notice to the
types of tests packages are running during installation.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 James Rowe 2005-03-19 06:49:01 UTC
Bah, submitted twice because it failed half way through but obviously just far enough through to submit.  My apologies.
Comment 2 James Rowe 2005-03-19 06:49:27 UTC

*** This bug has been marked as a duplicate of 85901 ***