Summary: | games-emulation/hatari-2.4.1 fails to compile (lto): savestate.h:272:14: error: type of savestate_fname does not match original declaration [-Werror=lto-type-mismatch] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | eschwartz93 |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/hatari/hatari/commit/adccd68b16eff815590c1ec993354ef8e752ecfd | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 618550 | ||
Attachments: | build.log |
Description
Agostino Sarubbo
2022-07-18 06:44:49 UTC
Created attachment 792062 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: -- Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE) FAILED: src/hatari /var/tmp/portage/games-emulation/hatari-2.4.0/work/hatari-2.4.0/src/cpu/savestate.h:272:14: error: type of ‘savestate_fname’ does not match original declaration [-Werror=lto-type-mismatch] Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2 lto_tinderbox has reproduced this issue with version 2.4.1 - Updating summary. Fixed upstream in git master. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e27a8a83982e24d3f02d16e6ff92ca5fb475e571 commit e27a8a83982e24d3f02d16e6ff92ca5fb475e571 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-14 04:52:10 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-14 06:05:30 +0000 games-emulation/hatari: backport fix for LTO https://github.com/hatari/hatari/commit/adccd68b16eff815590c1ec993354ef8e752ecfd Closes: https://bugs.gentoo.org/858704 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> .../adccd68b16eff815590c1ec993354ef8e752ecfd.patch | 36 ++++++++++++++++++++++ ...{hatari-2.4.1.ebuild => hatari-2.4.1-r1.ebuild} | 4 ++- 2 files changed, 39 insertions(+), 1 deletion(-) |