| Summary: | dev-util/hip-5.1.3-r1 fails to compile (lto): memory.cpp:1270:19: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | Gentoo Science Related Packages <sci> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | candrews, eschwartz93, gentoo |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://github.com/ROCm/clr/issues/64 https://bugs.gentoo.org/show_bug.cgi?id=856088 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 618550 | ||
| Attachments: | build.log | ||
|
Description
Agostino Sarubbo
2022-07-16 15:39:45 UTC
Created attachment 791744 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: src/CMakeFiles/rocclr.dir/var/tmp/portage/dev-util/hip-5.0.2-r2/work/ROCclr-rocm-5.0.2/platform/memory.cpp.o fatal: not a git repository (or any parent up to mount point /var/tmp) /var/tmp/portage/dev-util/hip-5.0.2-r2/work/ROCclr-rocm-5.0.2/platform/memory.cpp:1270:19: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2 lto_tinderbox has reproduced this issue with version 5.1.3-r1 - Updating summary. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=554481e2e6faedd753f33555358440a89ae02fbf commit 554481e2e6faedd753f33555358440a89ae02fbf Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-12 01:37:42 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-12 02:24:46 +0000 dev-util/hip: mark as LTO-unsafe, strict-aliasing unsafe Closes: https://bugs.gentoo.org/858383 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-util/hip/hip-5.7.1-r2.ebuild | 8 ++++++++ dev-util/hip/hip-6.0.0.ebuild | 8 ++++++++ 2 files changed, 16 insertions(+) |