Bug 857258 – app-text/xpdf-4.04[i18n] fails to build against useflag verify-sig

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Marco Clocchiatti 2022-07-10 12:36:32 UTC]

cloc3 ~ # emerge  xpdf
Calculating dependencies... done!

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) app-text/xpdf-4.04::gentoo
 * xpdf-4.04.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                          [ ok ]
 * xpdf-arabic.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                        [ ok ]
 * xpdf-chinese-simplified-20201222.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                   [ ok ]
 * xpdf-chinese-traditional-20201222.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                  [ ok ]
 * xpdf-cyrillic.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                      [ ok ]
 * xpdf-greek.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                         [ ok ]
 * xpdf-hebrew.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                        [ ok ]
 * xpdf-japanese-20201222.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                             [ ok ]
 * xpdf-korean-20201222.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                               [ ok ]
 * xpdf-latin2.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                        [ ok ]
 * xpdf-thai.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                          [ ok ]
 * xpdf-turkish.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                       [ ok ]
 * xpdf-4.04.tar.gz.sig BLAKE2B SHA512 size ;-) ...                                                                                                                                                                      [ ok ]
>>> Unpacking source...
 * The following distfiles lack detached signatures:
 *   xpdf-arabic.tar.gz
 *   xpdf-chinese-simplified-20201222.tar.gz
 *   xpdf-chinese-traditional-20201222.tar.gz
 *   xpdf-cyrillic.tar.gz
 *   xpdf-greek.tar.gz
 *   xpdf-hebrew.tar.gz
 *   xpdf-japanese-20201222.tar.gz
 *   xpdf-korean-20201222.tar.gz
 *   xpdf-latin2.tar.gz
 *   xpdf-thai.tar.gz
 *   xpdf-turkish.tar.gz
 * ERROR: app-text/xpdf-4.04::gentoo failed (unpack phase):
 *   Unsigned distfiles found
 * 
 * Call stack:
 *     ebuild.sh, line  127:  Called src_unpack
 *   environment, line 2591:  Called verify-sig_src_unpack
 *   environment, line 3452:  Called die
 * The specific snippet of code:
 *               die "Unsigned distfiles found";
 * 
 * If you need support, post the output of `emerge --info '=app-text/xpdf-4.04::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=app-text/xpdf-4.04::gentoo'`.
 * The complete build log is located at '/tmp/ramtmp/.znb/portage/app-text/xpdf-4.04/temp/build.log'.
 * The ebuild environment file is located at '/tmp/ramtmp/.znb/portage/app-text/xpdf-4.04/temp/environment'.
 * Working directory: '/tmp/ramtmp/.znb/portage/app-text/xpdf-4.04/work'
 * S: '/tmp/ramtmp/.znb/portage/app-text/xpdf-4.04/work/xpdf-4.04'

>>> Failed to emerge app-text/xpdf-4.04, Log file:

>>>  '/tmp/ramtmp/.znb/portage/app-text/xpdf-4.04/temp/build.log'

Reproducible: Always

[Comment 1 Marco Clocchiatti 2022-07-10 12:37:15 UTC]

Created attachment 790838 [details]
emerge --info

[Comment 2 Marco Clocchiatti 2022-07-10 12:37:35 UTC]

Created attachment 790841 [details]
build log

[Comment 3 Andrew Savchenko 2022-07-10 17:30:49 UTC]

Looks like some new feature or bug in verify-sig eclass: only main xpdf tarball has signature, so only it should be verified.

[Comment 4 Andrew Savchenko 2022-07-10 17:33:24 UTC]

OK, this can be fixed by custom src_unpack(). Will implement this later.

[Comment 5 Larry the Git Cow 2022-07-26 15:32:35 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4fd6556ce28bba04aafb277a2023677541ba2a10

commit 4fd6556ce28bba04aafb277a2023677541ba2a10
Author:     Andrew Savchenko <[e-mail]>
AuthorDate: 2022-07-26 15:26:33 +0000
Commit:     Andrew Savchenko <[e-mail]>
CommitDate: 2022-07-26 15:32:09 +0000

    app-text/xpdf: check singnature only for the source tarball
    
    Upstream provides GPG signature for the source tarball, but not for i18n
    charset tarballs. So manual verification of the source tarball is
    required instead of default verify-all action.
    
    Closes: https://bugs.gentoo.org/857258
    Signed-off-by: Andrew Savchenko <[e-mail]>

 app-text/xpdf/xpdf-4.04.ebuild | 7 +++++++
 1 file changed, 7 insertions(+)