| Summary: | dev-libs/rocr-runtime-5.7.1-r1 fails to compile (lto): si_gb_reg.h:91:3: error: type union GB_ADDR_CONFIG violates the C++ One Definition Rule [-Werror=odr] | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | Craig Andrews <candrews> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | admnd, eschwartz93, gentoo |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/ROCm/ROCR-Runtime/issues/182 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 618550 | ||
| Attachments: | build.log | ||
|
Description
Agostino Sarubbo
2022-07-03 07:39:12 UTC
Created attachment 789848 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: libhsa-runtime64.so.1.5.0 fatal: not a git repository (or any parent up to mount point /var/tmp) /var/tmp/portage/dev-libs/rocr-runtime-5.0.2/work/ROCR-Runtime-rocm-5.0.2/src/image/addrlib/src/chip/r800/si_gb_reg.h:91:3: error: type ‘union GB_ADDR_CONFIG’ violates the C++ One Definition Rule [-Werror=odr] Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2 lto_tinderbox has reproduced this issue with version 5.7.1-r1 - Updating summary. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dde18ab04c546545dfae709f39d7bf029662a541 commit dde18ab04c546545dfae709f39d7bf029662a541 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-12 01:21:45 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-12 02:24:46 +0000 dev-libs/rocr-runtime: mark as LTO-unsafe Closes: https://bugs.gentoo.org/856091 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-libs/rocr-runtime/rocr-runtime-5.7.1-r2.ebuild | 5 +++++ dev-libs/rocr-runtime/rocr-runtime-6.0.0-r1.ebuild | 5 +++++ 2 files changed, 10 insertions(+) |