Bug 85526 – tiny problem in fmirror causes not being able to connect to some sites

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Alin Dobre (RETIRED) 2005-03-16 10:15:18 UTC]

seems that the project is quite dead (site is not working -- the project is not a valid one), but that would not be a serious problem, as the application works.
i have sent an email to the upstream developer and responded MAILER-DAEMON (unknown user account) -- so this line is dead, too.

well, now the problem. i discovered this when trying to mirror a site that had SurgeFTP (www.netwinsite.com) as their FTP server. tried with wget, too, and it did connect to the ftp server w/o any problem. i looked into fmirror's source and found out that it sends after each command, only LF, instead of CRLF (RFC 959 states that each command must end with CRLF). the problem is located in the cmd() function, the problematic line being:
l = fprintf(out_file, "%s\n", buffer);
and it must be
l = fprintf(out_file, "%s\r\n", buffer);
(the \r byte added). after patching fmirror, everything worked fine.

i guess that surgeftp isn't the only ftp server that espects strictly the crlf pair, but many of the ftp servers running on windows.
here's a patch (tiny little one :P) that solves the problem, exactly as specified previously. the patch was result of the following command:
diff -Nut fmirror.c fmirror.c.new  > fmirror-crlf.patch

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Alin Dobre (RETIRED) 2005-03-16 10:15:57 UTC]

Created attachment 53637 [details, diff]
fmirror-crlf.patch

here's the tiny patch...

[Comment 2 Alin Dobre (RETIRED) 2005-03-16 10:35:59 UTC]

Created attachment 53639 [details, diff]
fmirror-ebuild.patch

here is the ebuild patch to the fmirror-0.8.4-r1 version, which solves this bug
(assumes that the patch is in the files/ directory, where it should belong, as
it is a very little patch).

[Comment 3 Seemant Kulleen (RETIRED) 2005-04-06 13:05:10 UTC]

Alin, thanks for the patch