Bug 855020

Summary:	app-text/mupdf-1.20.0 fails to compile (lto): cmsplugin.c:180:15: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Philipp Rösner <rndxelement>
Status:	RESOLVED FIXED
Severity:	normal	CC:	proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/26152 https://bugs.gentoo.org/show_bug.cgi?id=859907
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-06-29 07:24:09 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-text/mupdf-1.20.0 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Comment 1 Agostino Sarubbo gentoo-dev

2022-06-29 07:24:11 UTC

Created attachment 788603 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2022-06-30 12:45:51 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e69ffe486e072430217eb921a1886f93d8d74534

commit e69ffe486e072430217eb921a1886f93d8d74534
Author:     Philipp Rösner <rndxelement@protonmail.com>
AuthorDate: 2022-06-29 19:36:48 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-06-30 12:43:29 +0000

    app-text/mupdf: fix strict-aliasing violations
    
    Fix two issues in thirdparty/lcms2/src/cmsplugin.c regarding
    strinct-aliasing rule violations.
    
    Closes: https://bugs.gentoo.org/855020
    Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/26152
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 app-text/mupdf/files/mupdf-1.20.0-lcms2.patch | 20 ++++++++++++++++++++
 app-text/mupdf/mupdf-1.20.0.ebuild            |  1 +
 2 files changed, 21 insertions(+)

Comment 3 Florian Schmaus gentoo-dev

2022-06-30 13:35:54 UTC

Commit was reverted by 3b49a6d09605a565ec329c53ee4e5adcc8c9c2b0 [1].

1: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b49a6d09605a565ec329c53ee4e5adcc8c9c2b0

Comment 4 Larry the Git Cow gentoo-dev

2022-07-19 07:41:24 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a8ca257f22f4ca2eddaec6b04906d2a805c86134

commit a8ca257f22f4ca2eddaec6b04906d2a805c86134
Author:     Philipp Rösner <rndxelement@protonmail.com>
AuthorDate: 2022-06-29 19:36:48 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-07-19 07:35:54 +0000

    app-text/mupdf: fix strict-aliasing violations
    
    Fix two issues in thirdparty/lcms2/src/cmsplugin.c regarding
    strinct-aliasing rule violations.
    
    Issue: https://github.com/mm2/Little-CMS/issues/303
    PR: https://github.com/mm2/Little-CMS/pull/323
    
    Closes: https://bugs.gentoo.org/855020
    Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/26152
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 app-text/mupdf/files/mupdf-1.20.0-lcms2.patch | 69 +++++++++++++++++++++++++++
 app-text/mupdf/mupdf-1.20.0.ebuild            |  1 +
 2 files changed, 70 insertions(+)