| Summary: | app-emulation/fs-uae-3.1.66 fails to compile (lto): scsiemul.cpp:49:8: error: type [-Werror=odr] | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | James Le Cuirot <chewi> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | eschwartz93 |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 618550 | ||
| Attachments: | build.log | ||
|
Description
Agostino Sarubbo
2022-06-27 06:14:13 UTC
Created attachment 787877 [details]
build.log
build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2 Building from upstream git works. The latest release was in 2021, and there have been 1445 commits since then, ending in July 2022 which is approximately the last github activity by the upstream developer. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1b2d058e1207e6f5a4b63f6a5391fa4a3d79062b commit 1b2d058e1207e6f5a4b63f6a5391fa4a3d79062b Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-03 20:20:22 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-03 23:18:15 +0000 app-emulation/fs-uae: mark as LTO-unsafe Closes: https://bugs.gentoo.org/854519 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> app-emulation/fs-uae/fs-uae-3.1.66.ebuild | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) |