Summary: | dev-util/hip-5.0.2-r1 fails to compile | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Yiyang Wu <xgreenlandforwyy> |
Component: | Current packages | Assignee: | Gentoo Linux bug wranglers <bug-wranglers> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | heroxbd, xgreenlandforwyy |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
emerge --info output |
Description
Yiyang Wu
2022-06-22 08:59:42 UTC
Created attachment 786695 [details]
build.log
Created attachment 786698 [details]
emerge --info output
This cause is ${HIP_VERSION_BUILD_ID} defined in ${S}/CMakeLists.txt:129 is somehow lost when cmake processes to line 293. (In reply to Yiyang Wu from comment #3) > This cause is ${HIP_VERSION_BUILD_ID} defined in ${S}/CMakeLists.txt:129 is > somehow lost when cmake processes to line 293. Oh, so if git is not installed HIP_VERSION_BUILD_ID is not set. (In reply to Yiyang Wu from comment #4) > (In reply to Yiyang Wu from comment #3) > > This cause is ${HIP_VERSION_BUILD_ID} defined in ${S}/CMakeLists.txt:129 is > > somehow lost when cmake processes to line 293. > > Oh, so if git is not installed HIP_VERSION_BUILD_ID is not set. hip build depends on git... too bad. (In reply to Benda Xu from comment #5) > hip build depends on git... too bad. Should we add a BDEPEND or just patch it? Adding BDEPEND means we won't have to patch CMakeLists.txt, and future -9999.ebuild may benefit (upstream use git in cmake to determine various version strings). On the other hand this should be a upstream bug -- we should patch CMakelists and submit to upstream. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93ff73188c29fe12088f6166df669847cde9b2b4 commit 93ff73188c29fe12088f6166df669847cde9b2b4 Author: Yiyang Wu <xgreenlandforwyy@gmail.com> AuthorDate: 2022-06-22 11:39:27 +0000 Commit: Benda Xu <heroxbd@gentoo.org> CommitDate: 2022-06-22 13:00:00 +0000 dev-util/hip: fix build failure when git not installed Closes: https://bugs.gentoo.org/853718 Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com> Signed-off-by: Benda Xu <heroxbd@gentoo.org> dev-util/hip/files/hip-5.0.2-set-build-id.patch | 20 ++++++++++++++++++++ dev-util/hip/hip-5.0.2-r2.ebuild | 1 + 2 files changed, 21 insertions(+) (In reply to Yiyang Wu from comment #7) > On the other hand this should be a upstream bug -- we should patch > CMakelists and submit to upstream. Yes, please forward the patch upstream. |