Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 853271

Summary: sys-firmware/edk2-ovmf[-binary]: missing BDEPEND on sys-apps/which (please try remove it)
Product: Gentoo Linux Reporter: Sam James <sam>
Component: Current packagesAssignee: Virtualization Team <virtualization>
Status: RESOLVED FIXED    
Severity: normal CC: tamiko, virtualization
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/38813
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 646588    

Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-21 06:30:15 UTC
Please see if you can patch out the which usage instead of adding the BDEPEND though.

```
 * QA Notice: command not found:
 *
 *      ./OvmfPkg/build.sh: line 234: which: command not found
 *      ./OvmfPkg/build.sh: line 234: which: command not found
```

```
$ grep -rsin "which" --include=*.sh
MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/csharp/transpile.sh:1:if ! which mvn >/dev/null; then
MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/csharp/transpile.sh:6:if ! which mono >/dev/null; then
MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/csharp/transpile.sh:11:if ! which nuget >/dev/null; then
MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/csharp/transpile.sh:16:if ! which mcs >/dev/null; then
MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/scripts/.travis.sh:14:                    which ${CC} || brew install $(echo "${CC}" | sed 's/\-/@/') || brew link --overwrite $(echo "${CC}" | sed 's/\-/@/')
CryptoPkg/Library/OpensslLib/openssl/test/certs/setup.sh:235:# Name constraints subordinate CA. Adds www.good.net (which should be
CryptoPkg/Library/OpensslLib/openssl/test/certs/setup.sh:237:# (which should be allowed because parent allows *.good.com
CryptoPkg/Library/OpensslLib/openssl/test/certs/setup.sh:277:# hostname other.good.org which is not allowed by CA1.
CryptoPkg/Library/OpensslLib/openssl/util/opensslwrap.sh:16:    # and test/, which is now done elsewhere... The $PATH is adjusted
BaseTools/Source/C/BrotliCompress/brotli/csharp/transpile.sh:1:if ! which mvn >/dev/null; then
BaseTools/Source/C/BrotliCompress/brotli/csharp/transpile.sh:6:if ! which mono >/dev/null; then
BaseTools/Source/C/BrotliCompress/brotli/csharp/transpile.sh:11:if ! which nuget >/dev/null; then
BaseTools/Source/C/BrotliCompress/brotli/csharp/transpile.sh:16:if ! which mcs >/dev/null; then
BaseTools/Source/C/BrotliCompress/brotli/scripts/.travis.sh:14:                 which ${CC} || brew install $(echo "${CC}" | sed 's/\-/@/') || brew link --overwrite $(echo "${CC}" | sed 's/\-/@/')
OvmfPkg/build.sh:177:    elif  [ -x `which qemu-system-i386` ]; then
OvmfPkg/build.sh:179:    elif  [ -x `which qemu-system-x86_64` ]; then
OvmfPkg/build.sh:181:    elif  [ -x `which qemu` ]; then
OvmfPkg/build.sh:234:if  [[ ! -f `which build` || ! -f `which GenFv` ]];
OvmfPkg/build.sh:239:elif [[ ( -f `which build` ||  -f `which GenFv` )  && ! -d  $EDK_TOOLS_PATH/Source/C/bin ]];
OvmfPkg/AmdSev/Grub/grub.sh:66:    if which "$b" > /dev/null 2>&1; then
EmulatorPkg/build.sh:194:if  [[ ! -f `which build` || ! -f `which GenFv` ]];
EmulatorPkg/build.sh:199:elif [[ ( -f `which build` ||  -f `which GenFv` )  && ! -d  $EDK_TOOLS_PATH/Source/C/bin ]];
```
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-21 06:30:26 UTC
(edk2-ovmf-202105-r2, fwiw)
Comment 2 Larry the Git Cow gentoo-dev 2024-10-10 16:33:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=14804cc2b74bb38b68677ab2727d374be0cad71b

commit 14804cc2b74bb38b68677ab2727d374be0cad71b
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2024-09-25 16:42:44 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2024-10-10 16:29:34 +0000

    sys-firmware/edk2: Add missing BDEPEND on sys-apps/which
    
    The new version bump won't use this.
    
    Closes: https://bugs.gentoo.org/853271
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 sys-firmware/edk2/edk2-202202.ebuild | 1 +
 sys-firmware/edk2/edk2-202405.ebuild | 1 +
 2 files changed, 2 insertions(+)