Bug 853124

Summary:	sci-mathematics/singular patch to set htmldir has a bug
Product:	Gentoo Linux	Reporter:	François Bissey <frp.bissey>
Component:	Current packages	Assignee:	François Bissey <frp.bissey>
Status:	RESOLVED OBSOLETE
Severity:	normal	CC:	frp.bissey, mjo, proxy-maint, sci-mathematics
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description François Bissey 2022-06-20 00:50:26 UTC

While working to upstream my current patch to install html documentation in a location defined by configure I noticed that I introduced a bug now present in all available version of singular in Gentoo. At some point the patch must have been correct but now there is a mistake which should make it impossible to access html documentation from inside singular.

In line https://github.com/gentoo/gentoo/blob/master/sci-mathematics/singular/files/singular-4.1.3-doc_install.patch#L46
AC_DEFINE_UNQUOTED([HTML_DIR],"$config_datadir",[htmldir])
should actually be
AC_DEFINE_UNQUOTED([HTML_DIR],"$config_htmldir",[htmldir])

The mistake is also found in "doc-install" patch for previous versions.

For reference upstream is rejecting the current patch because they want a relative  location in feRessource.cc - which is fair enough.
https://github.com/Singular/Singular/pull/1138
it is while working on improving the PR that I noticed the mistake,.

Reproducible: Always

Comment 1 François Bissey 2022-06-22 02:28:07 UTC

I have been developing a new comprehensive solution at https://github.com/cschwan/sage-on-gentoo/tree/vbraun/sci-mathematics/singular and I will be feeding bits of it upstream progressively.

But the previous solution was half baked and missed bits. It looks like no one has ever used the bits that I was touching.

Comment 2 Michael Orlitzky gentoo-dev

2022-12-23 23:49:25 UTC

With the stabilization of 4.3.1_p1 and cleanup of earlier versions, these patches aren't used in ::gentoo any more. Is there anything left to do here?

Comment 3 François Bissey 2022-12-24 18:12:21 UTC

(In reply to Michael Orlitzky from comment #2)
> With the stabilization of 4.3.1_p1 and cleanup of earlier versions, these
> patches aren't used in ::gentoo any more. Is there anything left to do here?

I don't believe so. Can be closed.