Bug 852860

Summary:	sys-apps/kmod-29-r1: needs tighter zstd dep for USE=split-usr
Product:	Gentoo Linux	Reporter:	Duncan <1i5t5.duncan>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=771078
Whiteboard:
Package list:		Runtime testing required:	---

Description Duncan 2022-06-18 04:35:34 UTC

[This bug doesn't affect me as I'm both monolithic kernel and (reverse-)usr-merged, so no split-usr, but I found it investigating why my usual update pre-merge git-log scans seeming to indicate that I should be expecting a zstd update to go along with the kmod update (monolithic kernel so /shouldn't/ need kmod, but dracut depends on its libs), but I wasn't seeing it.]

Seems commit 80ef1c05e for kmod-29-r1, which *says* it depends on newer zstd with split-usr support, doesn't actually do so, because the depend it changes:

-       zstd? ( >=app-arch/zstd-1.4.4 )"
+       zstd? ( >=app-arch/zstd-1.5.1-r3:= )"

... ignores the fact that commit 1ae31721a which added that support to app-arch/zstd did so by adding zstd-1.5.1-r3, ignoring that 1.5.2 (still without that support) is max-visible for nearly everyone:

$ equery m -k app-arch/zstd
* app-arch/zstd [gentoo]
1.4.9:0/1: ~m68k
1.5.0:0/1:
1.5.1-r2:0/1:
1.5.1-r3:0/1:
1.5.2:0/1: amd64 arm arm64 hppa ppc ppc64 sparc x86 ~alpha ~amd64-linux ~ia64 ~loong ~mips ~ppc-macos ~riscv ~s390 ~sparc-solaris ~sparc64-solaris ~x64-macos
~x64-solaris ~x86-linux ~x86-solaris

Comment 1 Duncan 2022-06-18 04:43:45 UTC

CCing sam@, who made both commits.

[And please adjust bug title if there's a more concise way of saying it.]

Comment 2 Larry the Git Cow gentoo-dev

2022-06-18 13:05:01 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e5f5a24567c083d7615486bf0c58c968e01052ed

commit e5f5a24567c083d7615486bf0c58c968e01052ed
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-18 13:04:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-18 13:04:53 +0000

    sys-apps/kmod: tighten zstd dep
    
    Closes: https://bugs.gentoo.org/852860
    Bug: https://bugs.gentoo.org/771078
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/kmod/{kmod-29-r1.ebuild => kmod-29-r2.ebuild} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d3d6f195b3c875ddef2d642bd2d9c0ff27ffbf83

commit d3d6f195b3c875ddef2d642bd2d9c0ff27ffbf83
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-18 13:03:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-18 13:04:52 +0000

    app-arch/zstd: add 1.5.2-r1 for split-usr too
    
    Apparently I only did 1.5.1?
    
    Bug: https://bugs.gentoo.org/852860
    Signed-off-by: Sam James <sam@gentoo.org>

 app-arch/zstd/zstd-1.5.1-r3.ebuild |  2 +-
 app-arch/zstd/zstd-1.5.2-r1.ebuild | 66 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+), 1 deletion(-)