Bug 852752 – net-libs/webkit-gtk requesting removal of app-misc/geoclue dependency

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description ayuayuayu 2022-06-17 10:03:11 UTC]

app-misc/geoclue is not actually required at run-time.

my use case: on one website i use, with webkit-gtk compiled with USE=-geolocation, i cannot log in, while with webkit-gtk compiled with USE=geolocation and geoclue not installed, i can log in.

[Comment 1 ayuayuayu 2022-06-17 10:04:58 UTC]

Created attachment 785945 [details, diff]
webkit-gtk-2.36.1 ebuild patch

removes app-misc/geoclue dependency.
adds pkg_postinst message about optional use of app-misc/geoclue.

[Comment 2 Matt Turner 2022-06-17 21:44:38 UTC]

Interesting.

I'd suggest a few changes to the patch:

1) Remove the dependency on geoclue, as you've done, but use optfeature.eclass for the messages
2) Remove the IUSE=geolocation flag entirely and always enabled the functionality in webkit-gtk, since it doesn't add any dependencies.
3) Attach a git am'able patch (the output of `git format-patch`) with an appropriate Signed-off-by tag (a real name would be preferable).

Thanks!

[Comment 3 ayuayuayu 2022-06-18 04:41:15 UTC]

(In reply to Matt Turner from comment #2)
> 2) Remove the IUSE=geolocation flag entirely and always enabled the
> functionality in webkit-gtk, since it doesn't add any dependencies.
the ebuild currently has "geolocation? ( dev-util/gdbus-codegen )" in BDEPEND .
would this change the decision to keep/remove IUSE=geolocation ?

if removing IUSE=geolocation , should the ENABLE_GEOLOCATION line in src_configure also be removed?
it seems that ENABLE_GEOLOCATION defaults to ON if not specified.

Source/cmake/WebKitFeatures.cmake:
[...]
macro(WEBKIT_OPTION_DEFINE _name _description _public _initial_value)
[...]
    WEBKIT_OPTION_DEFINE(ENABLE_GEOLOCATION "Toggle Geolocation support" PRIVATE ON)
[...]

[Comment 4 Matt Turner 2022-06-18 12:58:38 UTC]

I would set it explicitly to ON.

[Comment 5 ayuayuayu 2022-06-19 05:37:01 UTC]

Created attachment 786101 [details, diff]
webkit-gtk-2.36.1 ebuild patch

[Comment 6 ayuayuayu 2022-06-20 04:27:02 UTC]

Created attachment 786371 [details, diff]
webkit-gtk-2.36.1 ebuild patch

incorporates bug 851027 commit:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e37a5481cdd16598433ce2da152471837f46ee2
which i only noticed today

[Comment 7 ayuayuayu 2022-06-20 04:41:48 UTC]

Created attachment 786374 [details, diff]
webkit-gtk-2.36.3 ebuild patch

analogous patch for webkit-gtk-2.36.3

[Comment 8 Matt Turner 2022-06-20 04:48:01 UTC]

Thanks. That looks good to me. I'll plan to apply it to the next webkit-gtk version, so as to avoid causing people a rebuild of such a large package.

[Comment 9 Larry the Git Cow 2022-07-05 16:38:47 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ee464019c9d81b327ec31a2d6da30f20fb8166f9

commit ee464019c9d81b327ec31a2d6da30f20fb8166f9
Author:     Matt Turner <[e-mail]>
AuthorDate: 2022-07-05 16:34:43 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2022-07-05 16:38:41 +0000

    net-libs/webkit-gtk: Version bump to 2.36.4
    
    * Apply patch from [e-mail] to remove IUSE=geolocation
      (bug #852752)
    
    Bug: https://bugs.gentoo.org/856445
    Closes: https://bugs.gentoo.org/852752
    Signed-off-by: Matt Turner <[e-mail]>

 net-libs/webkit-gtk/Manifest                 |   1 +
 net-libs/webkit-gtk/webkit-gtk-2.36.4.ebuild | 250 +++++++++++++++++++++++++++
 2 files changed, 251 insertions(+)