Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 852716

Summary: www-misc/monitorix-3.14.0-r1 installs shell script that uses non-POSIX features
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Pedro <dwosky>
Status: RESOLVED FIXED    
Severity: normal CC: dwosky, proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/28594
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 609070    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-06-17 06:50:51 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: www-misc/monitorix-3.14.0 installs shell script that uses non-POSIX features.
Discovered on: amd64 (internal ref: tinderbox)
Comment 1 Agostino Sarubbo gentoo-dev 2022-06-17 06:50:53 UTC
Created attachment 785885 [details]
build.log

build log and emerge --info
Comment 2 Pedro 2022-06-20 10:53:06 UTC
I suppose this line (12) on monitorix init.d script might be non-POSIX:
if [[ ! -e /etc/monitorix/monitorix.conf ]]; then

Have you identified any other lines in the code?
Comment 3 Agostino Sarubbo gentoo-dev 2022-11-22 16:01:55 UTC
ci has reproduced this issue with version 3.14.0-r1 - Updating summary.
Comment 4 Larry the Git Cow gentoo-dev 2023-01-07 07:57:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53cf3e6d17f6cd226c5a485d00475a0e9f28784a

commit 53cf3e6d17f6cd226c5a485d00475a0e9f28784a
Author:     Pedro Arizmendi <dwosky@pm.me>
AuthorDate: 2022-12-07 23:19:33 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-01-07 07:57:23 +0000

    www-misc/monitorix: Version bump to v3.15.0
    
    - Updated ebuild for version v3.15.0.
    - Updated init.d script to be POSIX compliant.
    
    Bug: https://bugs.gentoo.org/852716
    Signed-off-by: Pedro Arizmendi <dwosky@pm.me>
    Closes: https://github.com/gentoo/gentoo/pull/28594
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-misc/monitorix/Manifest                |   1 +
 www-misc/monitorix/files/monitorix         |   4 +-
 www-misc/monitorix/monitorix-3.15.0.ebuild | 118 +++++++++++++++++++++++++++++
 3 files changed, 121 insertions(+), 2 deletions(-)