Summary: | app-editors/nano: won't open after sed change | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sam James <sam> |
Component: | Current packages | Assignee: | Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gentoo, ionen |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=851726 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
~/.nanorc
/etc/nanorc |
Description
Sam James
2022-06-14 16:22:44 UTC
It happens in a chroot too but I'll attach the relevant files from my normal env. If you need more, let me know. Created attachment 785009 [details]
~/.nanorc
Created attachment 785012 [details]
/etc/nanorc
These are the packages that would be merged, in order: [ebuild R ] app-editors/nano-6.3-r1::gentoo USE="ncurses nls spell (unicode) -debug -justify -magic -minimal (-split-usr) -static" 0 KiB Total: 1 package (1 reinstall), Size of downloads: 0 KiB wrt original 0,// bug #851726, I don't quite get the report.. I'm assuming the reporter misunderstood the sed. It was removing '# ' /only/ on the include lines before which seems fine? "0,/^# include /" has a completely different meaning of matching all lines between line 0 and "# include", and removes the comments on /all/ of them (aka '# set' becomes 'set') (In reply to Ionen Wolkens from comment #5) > wrt original 0,// bug #851726, I don't quite get the report.. I'm assuming > the reporter misunderstood the sed. > > It was removing '# ' /only/ on the include lines before which seems fine? Oh I see, there's 3 example lines that end up including twice if not commented. I think the 0, suggestion is based on some examples going around but lacks context of this sed. (In reply to Ionen Wolkens from comment #6) > (In reply to Ionen Wolkens from comment #5) > > wrt original 0,// bug #851726, I don't quite get the report.. I'm assuming > > the reporter misunderstood the sed. > > > > It was removing '# ' /only/ on the include lines before which seems fine? > > Oh I see, there's 3 example lines that end up including twice if not > commented. I think the 0, suggestion is based on some examples going around > but lacks context of this sed. Could just be more specific about what it matches instead of tricks, like '/^# include.*\*.nanorc/s/^# // Fixed in https://bugs.gentoo.org/851726#c2. (In reply to Sam James from comment #8) > Fixed in https://bugs.gentoo.org/851726#c2. FWIW, the severity of this would've been greatly reduced if a revbump hadn't been done in stable too. It wasn't critical enough to require a git mv in stable. |