Summary: | sci-chemistry/pymol: fix distutils-r1 usage | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sam James <sam> |
Component: | Current packages | Assignee: | Gentoo Chemistry-Related Packages <sci-chemistry> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | python |
Priority: | Normal | Keywords: | NeedPatch |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=910021 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 803152 |
Description
Sam James
2022-06-12 16:08:15 UTC
Ping. I can't even get >pymol-2.5.0 to build because of improper use of mydistutilsargs: * ERROR: sci-chemistry/pymol-2.5.0-r2::gentoo failed (compile phase): * mydistutilsargs is banned in EAPI 8 (use DISTUTILS_ARGS) * * Call stack: * ebuild.sh, line 136: Called src_compile * environment, line 4279: Called distutils-r1_src_compile * environment, line 1964: Called _distutils-r1_run_foreach_impl 'distutils-r1_python_compile' * environment, line 743: Called python_foreach_impl 'distutils-r1_run_phase' 'distutils-r1_python_compile' * environment, line 3871: Called multibuild_foreach_variant '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'distutils-r1_python_compile' * environment, line 3404: Called _multibuild_run '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'distutils-r1_python_compile' * environment, line 3402: Called _python_multibuild_wrapper 'distutils-r1_run_phase' 'distutils-r1_python_compile' * environment, line 1177: Called distutils-r1_run_phase 'distutils-r1_python_compile' * environment, line 1946: Called distutils-r1_python_compile * environment, line 1752: Called esetup.py 'build' '-j' '9' * environment, line 2570: Called die * The specific snippet of code: * die "mydistutilsargs is banned in EAPI ${EAPI} (use DISTUTILS_ARGS)"; I don't know what are we meant to change and the equivalent (In reply to Pacho Ramos from comment #3) > I don't know what are we meant to change and the equivalent * wrt mydistutils args: It tells you: > * mydistutilsargs is banned in EAPI 8 (use DISTUTILS_ARGS) * wrt phase changes: don't call python_foreach_impl src_install etc, but instead define python_install(), repeat for each phase you call python_foreach_impl for. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e4cabe39a1ad71a44b89b696142bab6226291a4 commit 5e4cabe39a1ad71a44b89b696142bab6226291a4 Author: Pacho Ramos <pacho@gentoo.org> AuthorDate: 2023-07-19 08:26:10 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2023-07-19 08:28:05 +0000 sci-chemistry/pymol: Fix distutils-r1 usage Thanks-to: Sam James Closes: https://bugs.gentoo.org/851588 Signed-off-by: Pacho Ramos <pacho@gentoo.org> sci-chemistry/pymol/pymol-2.5.0-r3.ebuild | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) (In reply to Sam James from comment #4) > (In reply to Pacho Ramos from comment #3) > > I don't know what are we meant to change and the equivalent > > * wrt mydistutils args: It tells you: > > * mydistutilsargs is banned in EAPI 8 (use DISTUTILS_ARGS) > > * wrt phase changes: don't call python_foreach_impl src_install etc, but > instead define python_install(), repeat for each phase you call > python_foreach_impl for. Thanks I will follow in bug 910021 for the other migration... but last time I tried (some months ago) it was a disaster :S |