Bug 850760

Summary:	>=dev-vcs/git-2.35.1: remove deprecated GNU Emacs support (along with the "emacs" USE flag)
Product:	Gentoo Linux	Reporter:	Maciej Barć <xgqt>
Component:	Current packages	Assignee:	Robin Johnson <robbat2>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gnu-emacs, polynomial-c
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=194690 https://bugs.gentoo.org/show_bug.cgi?id=235393
Whiteboard:
Package list:		Runtime testing required:	---

Description Maciej Barć gentoo-dev

2022-06-09 15:27:29 UTC

USE=emacs in dev-vcs/git has little to no effect, except possible annoyances, that is because the Emacs Lisp libraries it ships with cannot be used.

This is the content of "/usr/share/emacs/site-lisp/git/git.el":
> (error "git.el no longer ships with git. It's recommended to
> replace its use with Magit, or simply delete references to git.el
> in your initialization file(s). See contrib/emacs/README in git's
> sources (https://github.com/git/git/blob/master/contrib/emacs/README)
> for suggested alternatives and for why this happened. Emacs's own
> VC mode and Magit are viable alternatives.")
Above file will throw a error while attempted to be loaded.

Checked with version dev-vcs/git-2.35.1.

Also see:
https://github.com/git/git/commit/6d5ed4836db94c07498e34ddebc31abbe532c8e1
https://github.com/git/git/blob/master/contrib/emacs/git.el
https://github.com/git/git/blob/master/contrib/emacs/git-blame.el

Comment 1 Maciej Barć gentoo-dev

2022-06-09 16:52:01 UTC

Also, see: https://lore.kernel.org/git/20180411204206.28498-1-avarab@gmail.com/

Comment 2 Maciej Barć gentoo-dev

2022-06-09 16:53:47 UTC

When removing "emacs" use flag we can instead rely on "optfeature" to inform the users about possibility of using magit - "app-emacs/magit" & print "einfo" that Emacs' "vc" can also be used.

Comment 3 Sam James archtester

2022-06-10 02:10:31 UTC

Nice spot.

Comment 4 Ulrich Müller gentoo-dev

2022-06-10 17:45:50 UTC

Right, we had already disabled the bundled elisp files for >=emacs-22 in 2007, see bug 194690. It was partially reenabled on user's request in bug 235393.

This no longer makes sense, so let's just remove the emacs flag. IMHO no need for optfeature.

Comment 5 Larry the Git Cow gentoo-dev

2022-06-11 06:31:06 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b84958e4b536ffc773078d98a57bf28ec0024018

commit b84958e4b536ffc773078d98a57bf28ec0024018
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-06-11 06:26:00 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-06-11 06:30:59 +0000

    dev-vcs/git: Drop emacs USE flag
    
    Closes: https://bugs.gentoo.org/850760
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 dev-vcs/git/files/50git-gentoo.el | 13 -------------
 dev-vcs/git/git-2.32.0-r1.ebuild  | 26 +++-----------------------
 dev-vcs/git/git-2.33.1.ebuild     | 26 +++-----------------------
 dev-vcs/git/git-2.34.1-r1.ebuild  | 26 +++-----------------------
 dev-vcs/git/git-2.34.1.ebuild     | 26 +++-----------------------
 dev-vcs/git/git-2.35.1.ebuild     | 26 +++-----------------------
 dev-vcs/git/git-2.35.2.ebuild     | 26 +++-----------------------
 dev-vcs/git/git-2.35.3.ebuild     | 26 +++-----------------------
 dev-vcs/git/git-2.36.0.ebuild     | 26 +++-----------------------
 dev-vcs/git/git-2.36.1.ebuild     | 26 +++-----------------------
 dev-vcs/git/git-9999-r1.ebuild    | 26 +++-----------------------
 dev-vcs/git/git-9999-r2.ebuild    | 26 +++-----------------------
 dev-vcs/git/git-9999-r3.ebuild    | 26 +++-----------------------
 dev-vcs/git/git-9999.ebuild       | 26 +++-----------------------
 14 files changed, 39 insertions(+), 312 deletions(-)