Summary: | bzip2 path hardcoded in gnome theme manager 2.10 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Matt Kynx <mattkyn> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
fix for hardcoded /usr/bin/bzip2 path
Proposed fix Updated fix |
Description
Matt Kynx
2005-03-12 10:04:47 UTC
Created attachment 53272 [details, diff] fix for hardcoded /usr/bin/bzip2 path I've entered this as a bug on gnome at: http://bugzilla.gnome.org/show_bug.cgi?id=170058 well, that 'fix' isnt any better it should either check both places or check PATH I have a patch that replaces the hardcoding with g_find_program_in_path() that I'm testing now. I'll run it past foser and company and commit once it's approved, and then submit upstream. Created attachment 59883 [details, diff]
Proposed fix
Proposed fix. It replaces hard coded binaries (tar, gzip, and bzip2) with
calls to g_find_program_in_path()
Created attachment 59885 [details, diff]
Updated fix
Here's an updated fix that removes all the conditionals around g_free(), as it
can correctly handle a NULL argument.
Fixed in CVS, patch pushed upstream. |